A platform for community discussion. Free, open, simple.
FIX: Reconcile like and reaction counters together in generic bulk import (#42794)
Ruben Oussoren9447cca2d4d2
diff --git a/script/bulk_import/generic_bulk.rb b/script/bulk_import/generic_bulk.rbindex d222f417814..64305897585 100644--- a/script/bulk_import/generic_bulk.rb+++ b/script/bulk_import/generic_bulk.rb@@ -111,7 +111,7 @@ class BulkImport::Generic < BulkImport::Baseimport_topic_allowed_usersimport_topic_allowed_groups- import_likes+ import_engagementimport_post_voting_votesimport_topic_voting_votesimport_answers@@ -150,10 +150,6 @@ class BulkImport::Generic < BulkImport::Baseupdate_chat_threadsupdate_chat_membership_metadata- import_reactions- import_reaction_users- import_reaction_shadow_likes-import_upload_referencesend@@ -1474,45 +1470,73 @@ class BulkImport::Generic < BulkImport::Baseendlikes.close+ end- puts "", "Updating like counts of posts..."+ def import_engagement+ import_likes+ import_reactions+ import_reaction_users+ import_reaction_shadow_likes++ puts "", "Updating engagement statistics..."start_time = Time.now+ update_engagement_stats+ puts " Update took #{(Time.now - start_time).to_i} seconds."+ end- DB.exec(<<~SQL)- UPDATE posts- SET like_count = (- SELECT COUNT(*)- FROM post_actions pa- WHERE pa.post_id = posts.id- AND pa.post_action_type_id = 2- AND pa.deleted_at IS NULL- )- WHERE id IN (- SELECT DISTINCT post_id- FROM post_actions- WHERE post_action_type_id = 2- AND deleted_at IS NULL- )+ def update_engagement_stats+ DB.exec(+ <<~SQL,+ WITH post_likes AS (+ SELECT post_actions.post_id,+ COUNT(*) AS like_count,+ SUM(+ CASE+ WHEN users.moderator OR users.admin THEN :staff_like_weight+ ELSE 1+ END+ ) AS like_score+ FROM post_actions+ LEFT JOIN users ON users.id = post_actions.user_id+ WHERE post_actions.post_action_type_id = :like_type_id+ AND post_actions.deleted_at IS NULL+ GROUP BY post_actions.post_id+ )+ UPDATE posts+ SET like_count = post_likes.like_count,+ like_score = post_likes.like_score+ FROM post_likes+ WHERE posts.id = post_likes.post_id+ SQL+ like_type_id: PostActionType::LIKE_POST_ACTION_ID,+ staff_like_weight: SiteSetting.staff_like_weight,+ )++ DB.exec(<<~SQL, whisper_post_type: Post.types[:whisper])+ WITH topic_likes AS (+ SELECT topic_id, SUM(like_count) AS like_count+ FROM posts+ WHERE deleted_at IS NULL+ AND post_type <> :whisper_post_type+ GROUP BY topic_id+ )+ UPDATE topics+ SET like_count = topic_likes.like_count+ FROM topic_likes+ WHERE topics.id = topic_likes.topic_id+ AND topics.like_count <> topic_likes.like_countSQL- puts " Update took #{(Time.now - start_time).to_i} seconds."-- puts "", "Updating like counts of topics..."- start_time = Time.now+ return unless defined?(DiscourseReactions)DB.exec(<<~SQL)- WITH- likes AS (- SELECT topic_id, SUM(like_count) AS like_count FROM posts WHERE like_count > 0 GROUP BY topic_id- )- UPDATE topics- SET like_count = likes.like_count- FROM likes- WHERE topics.id = likes.topic_id- AND topics.like_count <> likes.like_count+ UPDATE discourse_reactions_reactions+ SET reaction_users_count = (+ SELECT COUNT(*)+ FROM discourse_reactions_reaction_users+ WHERE discourse_reactions_reaction_users.reaction_id = discourse_reactions_reactions.id+ )SQL-- puts " Update took #{(Time.now - start_time).to_i} seconds."enddef import_topic_users