Skip to content

A platform for community discussion. Free, open, simple.

DEV: Flip ai_agents table rename strategy (#38592)

David Taylor958a52edeecf
diff --git a/plugins/discourse-ai/db/migrate/20260306000001_rename_ai_personas_to_ai_agents.rb b/plugins/discourse-ai/db/migrate/20260306000001_rename_ai_personas_to_ai_agents.rb
index e512c804dd5..02e25985249 100644
--- a/plugins/discourse-ai/db/migrate/20260306000001_rename_ai_personas_to_ai_agents.rb
+++ b/plugins/discourse-ai/db/migrate/20260306000001_rename_ai_personas_to_ai_agents.rb
@@ -2,15 +2,17 @@
class RenameAiPersonasToAiAgents < ActiveRecord::Migration[7.2]
def up
- # Create ai_agents as a view pointing to the real ai_personas table.
- # New code references ai_agents; old table stays intact until
- # FinalizeAiAgentsSchema post_migration does the actual rename.
- if table_exists?(:ai_personas) && !ActiveRecord::Base.connection.view_exists?(:ai_agents)
- execute "CREATE VIEW ai_agents AS SELECT * FROM ai_personas"
- end
+ Migration::SafeMigrate.disable!
+ rename_table :ai_personas, :ai_agents
+
+ # Backwards-compat view will be dropped immediately after deploy
+ # by FinalizeAiAgentsSchema post-deploy migration
+ execute "CREATE VIEW ai_personas AS SELECT * FROM ai_agents"
+ ensure
+ Migration::SafeMigrate.enable!
end
def down
- execute "DROP VIEW IF EXISTS ai_agents"
+ execute "DROP VIEW IF EXISTS ai_personas"
end
end
diff --git a/plugins/discourse-ai/db/post_migrate/20260306000002_finalize_ai_agents_schema.rb b/plugins/discourse-ai/db/post_migrate/20260306000002_finalize_ai_agents_schema.rb
index fe624a9b819..ad22be9d9c7 100644
--- a/plugins/discourse-ai/db/post_migrate/20260306000002_finalize_ai_agents_schema.rb
+++ b/plugins/discourse-ai/db/post_migrate/20260306000002_finalize_ai_agents_schema.rb
@@ -30,8 +30,11 @@ class FinalizeAiAgentsSchema < ActiveRecord::Migration[7.2]
}
def up
- # 0. Drop the forward-compat view and do the actual table rename
- execute "DROP VIEW IF EXISTS ai_agents"
+ # Older versions of RenameAiPersonasToAiAgents would create ai_agents as the view
+ # Newer versions perform the rename immediately and create ai_personas as the view
+ # Either way, we want to end up with ai_agents as the table and no view after this migration
+ execute "DROP VIEW ai_personas" if view_exists?(:ai_personas)
+ execute "DROP VIEW ai_agents" if view_exists?(:ai_agents)
if table_exists?(:ai_personas) && !table_exists?(:ai_agents)
rename_table :ai_personas, :ai_agents