Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Hidden group membership can be inferred via allowed_names and user_reasons

Keegan George97cbc569847c
diff --git a/app/controllers/composer_controller.rb b/app/controllers/composer_controller.rb
index 0ddffc58812..17ded67c584 100644
--- a/app/controllers/composer_controller.rb
+++ b/app/controllers/composer_controller.rb
@@ -124,7 +124,19 @@ class ComposerController < ApplicationController
end
def is_user_allowed?(user, user_ids, group_ids)
- user_ids.include?(user.id) || user.group_ids.any? { |group_id| group_ids.include?(group_id) }
+ user_ids.include?(user.id) ||
+ user.group_ids.any? do |group_id|
+ group_ids.include?(group_id) && visible_group_ids_for_allowed_check.include?(group_id)
+ end
+ end
+
+ def visible_group_ids_for_allowed_check
+ @visible_group_ids_for_allowed_check ||=
+ if @allowed_names.present?
+ Group.members_visible_groups(current_user).where(name: @allowed_names).pluck(:id).to_set
+ else
+ topic_allowed_group_ids || Set.new
+ end
end
def users
diff --git a/spec/requests/composer_controller_spec.rb b/spec/requests/composer_controller_spec.rb
index 78b2e8ada3a..d7291727987 100644
--- a/spec/requests/composer_controller_spec.rb
+++ b/spec/requests/composer_controller_spec.rb
@@ -288,6 +288,34 @@ RSpec.describe ComposerController do
end
end
+ context "with a new private message to a group with hidden members" do
+ fab!(:alice) { Fabricate(:user, username: "alice") }
+ fab!(:bob) { Fabricate(:user, username: "bob") }
+ fab!(:hidden_members_group) do
+ Fabricate(
+ :group,
+ messageable_level: Group::ALIAS_LEVELS[:everyone],
+ mentionable_level: Group::ALIAS_LEVELS[:everyone],
+ members_visibility_level: Group.visibility_levels[:staff],
+ )
+ end
+
+ before { hidden_members_group.add(alice) }
+
+ it "does not leak hidden group membership via user_reasons" do
+ get "/composer/mentions.json",
+ params: {
+ names: [alice.username, bob.username],
+ allowed_names: [hidden_members_group.name],
+ }
+
+ expect(response.status).to eq(200)
+
+ user_reasons = response.parsed_body["user_reasons"]
+ expect(user_reasons[alice.username]).to eq(user_reasons[bob.username])
+ end
+ end
+
context "with invalid allowed_names parameter" do
it "returns 400 when allowed_names is not an array" do
get "/composer/mentions.json",