A platform for community discussion. Free, open, simple.
FIX: return empty string for invalid date (#41467)
Kris983d381da0e2
diff --git a/frontend/discourse/app/lib/formatter.js b/frontend/discourse/app/lib/formatter.jsindex 72a4b935498..5393e154344 100644--- a/frontend/discourse/app/lib/formatter.js+++ b/frontend/discourse/app/lib/formatter.js@@ -72,7 +72,7 @@ export function updateRelativeAge(elems) {}export function autoUpdatingRelativeAge(date, options) {- if (!date) {+ if (!date || isNaN(date.getTime())) {return "";}if (+date === +new Date(0)) {diff --git a/frontend/discourse/tests/unit/lib/formatter-test.js b/frontend/discourse/tests/unit/lib/formatter-test.jsindex 74a4db3d4df..54afb2d3531 100644--- a/frontend/discourse/tests/unit/lib/formatter-test.js+++ b/frontend/discourse/tests/unit/lib/formatter-test.js@@ -260,6 +260,17 @@ module("Unit | Utility | formatter", function (hooks) {elem = domFromString(autoUpdatingRelativeAge(d, { prefix: "test" }))[0];assert.dom(elem).hasHtml("test 1d");++ assert.strictEqual(+ autoUpdatingRelativeAge(null),+ "",+ "it returns an empty string for a missing date"+ );+ assert.strictEqual(+ autoUpdatingRelativeAge(new Date(undefined), { format: "medium" }),+ "",+ "it returns an empty string for an invalid date"+ );});test("updateRelativeAge", function (assert) {