A platform for community discussion. Free, open, simple.
SECURITY: Private message invite can see topic
Isaac Janzen98857b0f29a9
diff --git a/app/controllers/invites_controller.rb b/app/controllers/invites_controller.rbindex 6e6dbe02d84..1f9337ffdf5 100644--- a/app/controllers/invites_controller.rb+++ b/app/controllers/invites_controller.rb@@ -210,6 +210,8 @@ class InvitesController < ApplicationControllerguardian.ensure_can_invite_to!(topic)end+ invite.topics.each { |t| guardian.ensure_can_invite_to!(t) } if !params.has_key?(:topic_id)+if params[:group_ids].present? || params[:group_names].present?groups = Group.lookup_groups(group_ids: params[:group_ids], group_names: params[:group_names])enddiff --git a/spec/requests/invites_controller_spec.rb b/spec/requests/invites_controller_spec.rbindex a195dd99fbf..ac1a2dfb51f 100644--- a/spec/requests/invites_controller_spec.rb+++ b/spec/requests/invites_controller_spec.rb@@ -916,6 +916,20 @@ RSpec.describe InvitesController doendendend++ context "when invite is linked to a PM topic the user no longer has access to" do+ it "returns an error when updating the email without providing topic_id" do+ sign_in(user)+ pm_topic = Fabricate(:private_message_topic, user: user)+ invite = Fabricate(:invite, invited_by: user, email: "[email protected]")+ TopicInvite.create!(invite: invite, topic: pm_topic)++ pm_topic.topic_allowed_users.where(user_id: user.id).destroy_all++ put "/invites/#{invite.id}.json", params: { email: "[email protected]" }+ expect(response.status).to eq(403)+ end+ endendend