A platform for community discussion. Free, open, simple.
FIX: clear patreon warning on successful response (#42332)
Kris995b20ff9513
diff --git a/plugins/discourse-patreon/lib/api.rb b/plugins/discourse-patreon/lib/api.rbindex 7747cda3757..8cc8a003a37 100644--- a/plugins/discourse-patreon/lib/api.rb+++ b/plugins/discourse-patreon/lib/api.rb@@ -54,6 +54,11 @@ module Patreoncase response.statuswhen 200+ # An inline check is never re-evaluated elsewhere, so a successful+ # response is the only thing that can resolve it.+ tracker = ProblemCheckTracker[:access_token_invalid]+ tracker.no_problem! if tracker.failing?+return JSON.parse response.bodywhen 401ProblemCheckTracker[:access_token_invalid].problem!diff --git a/plugins/discourse-patreon/spec/lib/api_spec.rb b/plugins/discourse-patreon/spec/lib/api_spec.rbindex ac4d029dc52..1b7e82cf517 100644--- a/plugins/discourse-patreon/spec/lib/api_spec.rb+++ b/plugins/discourse-patreon/spec/lib/api_spec.rb@@ -56,7 +56,23 @@ RSpec.describe Patreon::Api doit "should not add admin warning message for valid api response" dostub_url(200, url)+ described_class.campaign_data++ expect(ProblemCheckTracker[:access_token_invalid].blips).to eq(0)+ expect(AdminNotice.find_by(identifier: :access_token_invalid)).to eq(nil)+ end++ it "should clear an existing admin warning message once the api responds again" do+ stub_url(401, url)+ described_class.campaign_data+ expect(AdminNotice.find_by(identifier: :access_token_invalid)).to be_present++ stub_url(200, url)+ described_class.campaign_data+expect(ProblemCheckTracker[:access_token_invalid].blips).to eq(0)+ expect(ProblemCheckTracker[:access_token_invalid]).to be_passing+ expect(AdminNotice.find_by(identifier: :access_token_invalid)).to eq(nil)endit "should add warning log" do