A platform for community discussion. Free, open, simple.
FIX: Allow deleting the final tag localization (#43345)
Natalie Taya0407f8f6e3b
diff --git a/app/services/tag_settings_updater.rb b/app/services/tag_settings_updater.rbindex 8ebf7310663..416c1666c3e 100644--- a/app/services/tag_settings_updater.rb+++ b/app/services/tag_settings_updater.rb@@ -73,7 +73,7 @@ class TagSettingsUpdaterenddef update_localizations(localizations)- return if localizations.blank?+ return if localizations.nil?submitted_locales = []diff --git a/spec/services/tag_settings_updater_spec.rb b/spec/services/tag_settings_updater_spec.rbindex afa5df058a8..5c05aa2940e 100644--- a/spec/services/tag_settings_updater_spec.rb+++ b/spec/services/tag_settings_updater_spec.rb@@ -169,6 +169,10 @@ describe TagSettingsUpdater doexpect(TagLocalization.find_by(tag_id: tag.id, locale: "es")).to be_presentexpect(TagLocalization.find_by(tag_id: tag.id, locale: "it")).to be_nil++ TagSettingsUpdater.update(tag, admin, { localizations: [] })++ expect(TagLocalization.where(tag_id: tag.id)).to be_emptyendendenddiff --git a/spec/system/page_objects/pages/tag_settings.rb b/spec/system/page_objects/pages/tag_settings.rbindex 77e14a22864..ce3046ad79e 100644--- a/spec/system/page_objects/pages/tag_settings.rb+++ b/spec/system/page_objects/pages/tag_settings.rb@@ -51,6 +51,19 @@ module PageObjectsselfend+ def remove_localization+ find(".form-kit__collection .btn-danger").click+ self+ end++ def has_localizations?+ has_css?(".form-kit__collection")+ end++ def has_no_localizations?+ has_no_css?(".form-kit__collection")+ end+def name_inputfind("input[name='name']")enddiff --git a/spec/system/tag_settings_spec.rb b/spec/system/tag_settings_spec.rbindex 533314d8e4d..a34352ba2d4 100644--- a/spec/system/tag_settings_spec.rb+++ b/spec/system/tag_settings_spec.rb@@ -72,6 +72,10 @@ describe "Tag Settings" doendit "allows privileged users to edit tag, admin to delete tag" do+ SiteSetting.content_localization_enabled = true+ tag_1.update!(locale: "en")+ Fabricate(:tag_localization, tag: tag_1, locale: "de", name: "gestaltung")+sign_in(trust_level_4)tags_page.visit_tag(tag_1)tags_page.edit_tag_btn.click@@ -98,6 +102,18 @@ describe "Tag Settings" doexpect(tag_settings_page).to have_no_synonymssign_in(admin)+ tag_1.reload+ tag_settings_page.visit_tab(tag_1, "localizations")+ expect(tag_settings_page).to have_localizations+ tag_settings_page.remove_localization+ tag_settings_page.click_save++ expect(toasts).to have_success(I18n.t("js.tagging.settings.saved"))++ page.refresh++ expect(tag_settings_page).to have_no_localizations+tags_page.visit_tag(tag_2)tags_page.edit_tag_btn.clickexpect(page).to have_css(".d-page-header__actions .btn-danger")