A platform for community discussion. Free, open, simple.
PERF: Speed up category visibility checks (#41977)
Alan Guo Xiang Tana1fed66c9100
diff --git a/lib/guardian/category_guardian.rb b/lib/guardian/category_guardian.rbindex 0bf7bb5b811..0790495b54f 100644--- a/lib/guardian/category_guardian.rb+++ b/lib/guardian/category_guardian.rb@@ -31,7 +31,7 @@ module CategoryGuardianread_restricted = true unless !!read_restricted == read_restrictedreturn true if !read_restricted- secure_category_ids.include?(category_id)+ secure_category_ids_set.include?(category_id)enddef can_see_category?(category)@@ -39,7 +39,7 @@ module CategoryGuardianreturn true if is_admin? && !SiteSetting.suppress_secured_categories_from_adminreturn true if !category.read_restrictedreturn true if is_staged? && category.email_in.present? && category.email_in_allow_strangers- secure_category_ids.include?(category.id)+ secure_category_ids_set.include?(category.id)enddef can_post_in_category?(category)@@ -81,6 +81,10 @@ module CategoryGuardianprivate+ def secure_category_ids_set+ @secure_category_ids_set ||= secure_category_ids.to_set+ end+def posting_review_required?(category, post_type)return false if category.nil?