A platform for community discussion. Free, open, simple.
DEV: Restore and fix post-event specs (#39524)
Jarek Radosza41bdfbb944e
diff --git a/plugins/discourse-calendar/spec/system/page_objects/discourse_calendar/post_event.rb b/plugins/discourse-calendar/spec/system/page_objects/discourse_calendar/post_event.rbindex 2ab611094da..7cb22c6b304 100644--- a/plugins/discourse-calendar/spec/system/page_objects/discourse_calendar/post_event.rb+++ b/plugins/discourse-calendar/spec/system/page_objects/discourse_calendar/post_event.rb@@ -7,12 +7,16 @@ module PageObjectsTRIGGER_MENU_SELECTOR = ".discourse-post-event-more-menu-trigger"def open_more_menu- find(TRIGGER_MENU_SELECTOR).click+ # post-event component re-renders on a post re-cook and message_bus+ # events, so we need to retry on stale refs (hence `synchronize`)+ page.document.synchronize { find("#{TRIGGER_MENU_SELECTOR}:not(.--saving)").click }++ has_css?(".discourse-post-event-more-menu-content")selfenddef going- find(".going-button").click+ page.document.synchronize { find(".going-button").click }selfenddiff --git a/plugins/discourse-calendar/spec/system/post_event_spec.rb b/plugins/discourse-calendar/spec/system/post_event_spec.rbindex dad04aea914..7dbc72afe99 100644--- a/plugins/discourse-calendar/spec/system/post_event_spec.rb+++ b/plugins/discourse-calendar/spec/system/post_event_spec.rb@@ -88,9 +88,7 @@ describe "Post event" doendcontext "with max attendees" do- # FIXME: flaky because `post_event_page.going` sometimes runs before- # the post component re-renders- xit "updates the going button label from Full after toggling" do+ it "updates the going button label from Full after toggling" dotitle = "My test meetup event"raw = "[event status='public' start='2222-02-22 14:22' max-attendees='1']\n[/event]"post = PostCreator.create(admin, title:, raw:)@@ -175,9 +173,7 @@ describe "Post event" doexpect(page).to have_css(".event-info .name", text: "<script>alert(1);</script>")end- # FIXME: flaky because `post_event_page.going`/`open_more_menu`- # sometimes run before the post component re-renders- xit "can create, close, and open an event" do+ it "can create, close, and open an event" dovisit "/new-topic"title = "My upcoming l33t event"tomorrow = (1.day.from_now).strftime("%Y-%m-%d")@@ -204,9 +200,7 @@ describe "Post event" doexpect(event.invitees.count).to eq(2)end- # FIXME: flaky because `post_event_page.open_more_menu` sometimes runs- # before the post component re-renders- xit "does not show participants button when event is standalone" do+ it "does not show participants button when event is standalone" dotitle = "My standalone event"raw = "[event name='standalone-event' status='standalone' start='2222-02-22 00:00']\n[/event]"post = PostCreator.create(admin, title:, raw:)@@ -217,9 +211,7 @@ describe "Post event" doexpect(page).to have_no_css(".show-all-participants")end- # FIXME: flaky because `post_event_page.open_more_menu` sometimes runs- # before the post component re-renders- xit "does not show 'send pm' button to the user who created the event" do+ it "does not show 'send pm' button to the user who created the event" dotitle = "My test meetup event"raw = "[event name='cool-event' status='public' start='2222-02-22 00:00']\n[/event]"post = PostCreator.create(admin, title:, raw:)