Skip to content

A platform for community discussion. Free, open, simple.

FIX: Allow workflow topic admin buttons on deleted topics

Régis Hanola9cf53ebad4c
diff --git a/plugins/discourse-workflows/app/services/discourse_workflows/workflow/trigger_topic_admin_button.rb b/plugins/discourse-workflows/app/services/discourse_workflows/workflow/trigger_topic_admin_button.rb
index a26f0f962bb..74f3fbd7c72 100644
--- a/plugins/discourse-workflows/app/services/discourse_workflows/workflow/trigger_topic_admin_button.rb
+++ b/plugins/discourse-workflows/app/services/discourse_workflows/workflow/trigger_topic_admin_button.rb
@@ -29,7 +29,7 @@ module DiscourseWorkflows
end
def fetch_topic(params:)
- Topic.find_by(id: params.topic_id)
+ Topic.with_deleted.find_by(id: params.topic_id)
end
def enqueue_workflow(published_trigger:, topic:, guardian:)
diff --git a/plugins/discourse-workflows/spec/services/discourse_workflows/workflow/trigger_topic_admin_button_spec.rb b/plugins/discourse-workflows/spec/services/discourse_workflows/workflow/trigger_topic_admin_button_spec.rb
index c4d983f8454..f6bababb6c9 100644
--- a/plugins/discourse-workflows/spec/services/discourse_workflows/workflow/trigger_topic_admin_button_spec.rb
+++ b/plugins/discourse-workflows/spec/services/discourse_workflows/workflow/trigger_topic_admin_button_spec.rb
@@ -60,6 +60,12 @@ RSpec.describe DiscourseWorkflows::Workflow::TriggerTopicAdminButton do
it { is_expected.to fail_to_find_a_model(:topic) }
end
+ context "when topic is deleted" do
+ before { topic.trash!(admin) }
+
+ it { is_expected.to run_successfully }
+ end
+
context "when everything is valid" do
it { is_expected.to run_successfully }