Skip to content

A platform for community discussion. Free, open, simple.

DEV: Filter hidden posts from duplicate link lookup (#38543)

Isaac Janzenaa9bdb72eb5b
diff --git a/app/models/topic_link.rb b/app/models/topic_link.rb
index 7675576d8e6..fdace59cb60 100644
--- a/app/models/topic_link.rb
+++ b/app/models/topic_link.rb
@@ -183,6 +183,7 @@ class TopicLink < ActiveRecord::Base
.joins(:post, :user)
.where("posts.id IS NOT NULL AND users.id IS NOT NULL")
.where(topic_id: topic.id, reflection: false)
+ .where(posts: { hidden: false })
.last(200)
lookup = {}
diff --git a/spec/requests/composer_messages_controller_spec.rb b/spec/requests/composer_messages_controller_spec.rb
index 76e57abb7e7..72da81c66bb 100644
--- a/spec/requests/composer_messages_controller_spec.rb
+++ b/spec/requests/composer_messages_controller_spec.rb
@@ -28,6 +28,25 @@ RSpec.describe ComposerMessagesController do
json = response.parsed_body
expect(json["composer_messages"].first["id"]).to eq("education")
end
+
+ it "does not include links from hidden posts in duplicate_lookup" do
+ reply =
+ Fabricate(
+ :post,
+ topic: topic,
+ user: Fabricate(:user, refresh_auto_groups: true),
+ raw: "Check out https://example.com/private-doc for details",
+ )
+ TopicLink.extract_from(reply)
+ reply.hide!(PostActionType.types[:spam])
+
+ get "/composer_messages.json", params: { topic_id: topic.id, composer_action: "reply" }
+ expect(response.status).to eq(200)
+
+ json = response.parsed_body
+ duplicate_lookup = json["extras"]["duplicate_lookup"]
+ expect(duplicate_lookup).not_to have_key("example.com/private-doc")
+ end
end
end