A platform for community discussion. Free, open, simple.
SECURITY: exclude_groups enables private group membership inference without authorization
Keegan Georgeb15e91727867
diff --git a/app/controllers/directory_items_controller.rb b/app/controllers/directory_items_controller.rbindex bf22f82eeb8..f31d8d78fa2 100644--- a/app/controllers/directory_items_controller.rb+++ b/app/controllers/directory_items_controller.rb@@ -152,7 +152,9 @@ class DirectoryItemsController < ApplicationControllerdef set_groups_exclusion@exclude_group_names = params[:exclude_groups].split("|")- @exclude_group_ids = Group.where(name: @exclude_group_names).pluck(:id)+ groups = Group.where(name: @exclude_group_names)+ groups = groups.select { |g| guardian.can_see?(g) && guardian.can_see_group_members?(g) }+ @exclude_group_ids = groups.map(&:id)@users_in_exclude_groups = GroupUser.where(group_id: @exclude_group_ids).pluck(:user_id)enddiff --git a/spec/requests/directory_items_controller_spec.rb b/spec/requests/directory_items_controller_spec.rbindex 48566c28859..1b877ab3d06 100644--- a/spec/requests/directory_items_controller_spec.rb+++ b/spec/requests/directory_items_controller_spec.rb@@ -70,6 +70,56 @@ RSpec.describe DirectoryItemsController douser_names = json["directory_items"].map { |item| item["user"]["username"] }expect(user_names).to include("eviltrout")end++ it "does not allow anonymous users to exclude private groups" do+ secret_group =+ Fabricate(+ :group,+ name: "secret_group",+ members_visibility_level: Group.visibility_levels[:members],+ )+ secret_group.add(evil_trout)+ DirectoryItem.refresh!++ get "/directory_items.json", params: { period: "all", username: evil_trout.username }+ expect(response.status).to eq(200)+ expect(response.parsed_body["directory_items"].length).to eq(1)++ get "/directory_items.json",+ params: {+ period: "all",+ username: evil_trout.username,+ exclude_groups: "secret_group",+ }+ expect(response.status).to eq(200)+ expect(response.parsed_body["directory_items"].length).to eq(1)+ end++ it "does not allow a regular user to exclude groups with non-public member visibility" do+ secret_group =+ Fabricate(+ :group,+ name: "secret_group",+ members_visibility_level: Group.visibility_levels[:staff],+ )+ secret_group.add(evil_trout)+ DirectoryItem.refresh!++ sign_in(user)++ get "/directory_items.json", params: { period: "all", username: evil_trout.username }+ expect(response.status).to eq(200)+ baseline_count = response.parsed_body["directory_items"].length++ get "/directory_items.json",+ params: {+ period: "all",+ username: evil_trout.username,+ exclude_groups: "secret_group",+ }+ expect(response.status).to eq(200)+ expect(response.parsed_body["directory_items"].length).to eq(baseline_count)+ endendcontext "with exclude_groups parameter and current user in the top positions" do