A platform for community discussion. Free, open, simple.
FEATURE: Add upcoming change defaulting whispers allowed groups to staff (#44418)
Régis Hanolb1893337d49b
diff --git a/config/locales/server.en.yml b/config/locales/server.en.ymlindex fd116c44510..ab33af79434 100644--- a/config/locales/server.en.yml+++ b/config/locales/server.en.yml@@ -3216,6 +3216,7 @@ en:improved_crawler_detection: "Enables improved crawler tracking which can better detect likely crawlers and ensure traffic reporting is more accurate."enable_invite_modal_with_roles: "Enables a redesigned invite flow that lets admins invite someone directly as an admin. The invitee becomes a moderator on signup and an admin once the inviter confirms via email."update_pending_users_reminder_default: "We are updating the default for the {{setting:pending_users_reminder_delay_minutes}} setting to 30 minutes so that staff are promptly notified when a new member is waiting for approval. If you have previously changed this setting, this change will have no effect."+ update_whispers_allowed_groups_default: "We are updating the default for the {{setting:whispers_allowed_groups}} setting to allow staff to post whispers by default. If you have previously changed this setting, your configuration will not change unless you reset the setting."sidebar_user_navigation: "Moves the navigation for user pages — profile, activity, notifications, messages, invites and preferences — out of the horizontal tab bars and into a dedicated sidebar panel, the way the admin area works. On mobile the panel is served from the hamburger menu."enable_generated_llms_txt: "Generates a concise /llms.txt when no custom file is uploaded. The document describes public discovery routes, the preferred Discourse MCP interface, and responsible agent access. To tune automated access, configure {{setting:slow_down_crawler_user_agents}} and {{setting:slow_down_crawler_rate}}."enable_markdown_endpoints: "Serve supported topics and topic lists as Markdown through .md URLs and requests with an Accept: text/markdown header. Normal visibility and profile privacy rules always apply."diff --git a/config/site_settings.yml b/config/site_settings.ymlindex ed28f94ac06..f8c4d4b5717 100644--- a/config/site_settings.yml+++ b/config/site_settings.yml@@ -465,6 +465,9 @@ basic:refresh: truedisallowed_groups: "0|4|5"area: "group_permissions"+ upcoming_change_default_override:+ upcoming_change: "update_whispers_allowed_groups_default"+ new_default: "3"hidden_post_visible_groups:type: group_listlist_type: compact@@ -5015,6 +5018,17 @@ experimental:permanent_warning: falseallow_enabled_for:- everyone+ update_whispers_allowed_groups_default:+ default: false+ hidden: true+ client: true+ upcoming_change:+ status: "alpha"+ impact: "site_setting_default,staff"+ learn_more_url: "https://meta.discourse.org/t/-/414354"+ permanent_warning: false+ allow_enabled_for:+ - everyonesidebar_user_navigation:default: falsehidden: truediff --git a/spec/models/site_setting_spec.rb b/spec/models/site_setting_spec.rbindex 53b408dc261..9c824c9ba8b 100644--- a/spec/models/site_setting_spec.rb+++ b/spec/models/site_setting_spec.rb@@ -68,6 +68,16 @@ RSpec.describe SiteSetting doendend+ describe "whispers_allowed_groups" do+ it "defaults to staff while the update_whispers_allowed_groups_default change is enabled" do+ expect(SiteSetting.whispers_allowed_groups).to eq("")++ SiteSetting.update_whispers_allowed_groups_default = true+ expect(SiteSetting.whispers_allowed_groups).to eq(Group::AUTO_GROUPS[:staff].to_s)+ expect(Fabricate(:moderator)).to be_a_whisperer+ end+ end+describe "top_menu" dodescribe "validations" doit "always demands latest" do