A platform for community discussion. Free, open, simple.
SECURITY: Missing visibility check in click tracking endpoint (#41140)
Samb2c3c1cae87a
diff --git a/app/controllers/clicks_controller.rb b/app/controllers/clicks_controller.rbindex 59dabcd121b..64c40359eb3 100644--- a/app/controllers/clicks_controller.rb+++ b/app/controllers/clicks_controller.rb@@ -12,6 +12,7 @@ class ClicksController < ApplicationControllertopic_id: params[:topic_id],ip: request.remote_ip,user_id: current_user&.id,+ guardian: guardian,)render json: success_jsondiff --git a/app/models/topic_link_click.rb b/app/models/topic_link_click.rbindex 762f1aeff0c..c44d9e27268 100644--- a/app/models/topic_link_click.rb+++ b/app/models/topic_link_click.rb@@ -103,6 +103,9 @@ class TopicLinkClick < ActiveRecord::Basereturn nilend+ guardian = args[:guardian]+ return nil if guardian && !(guardian.can_see?(link.topic) && guardian.can_see?(link.post))+return url if args[:user_id] && link.user_id == args[:user_id]# Rate limit the click counts to once in 24 hoursdiff --git a/spec/requests/clicks_controller_spec.rb b/spec/requests/clicks_controller_spec.rbindex 8a6e0523f29..04c5cd9dd81 100644--- a/spec/requests/clicks_controller_spec.rb+++ b/spec/requests/clicks_controller_spec.rb@@ -1,13 +1,17 @@# frozen_string_literal: trueRSpec.describe ClicksController do+ fab!(:user, :trust_level_1)+ fab!(:recipient, :trust_level_1)+ fab!(:unauthorized_user, :user)+let(:url) { "https://discourse.org/" }let(:headers) { { REMOTE_ADDR: "192.168.0.1" } }let(:post_with_url) { create_post(raw: "this is a post with a link #{url}") }describe "#track" doit "creates a TopicLinkClick" do- sign_in(Fabricate(:user))+ sign_in(user)expect {post "/clicks/track",@@ -18,6 +22,63 @@ RSpec.describe ClicksController do},headers: headers}.to change { TopicLinkClick.count }.by(1)++ expect(response.status).to eq(200)+ expect(response.parsed_body["success"]).to eq("OK")+ end++ it "creates a TopicLinkClick for a private message post the recipient can see" do+ private_url = "https://example.com/private-recipient-click-test"+ private_message_post =+ create_post(+ user: user,+ archetype: Archetype.private_message,+ target_usernames: [recipient.username],+ raw: "this private message has a link #{private_url}",+ )+ expect(private_message_post.topic_links.find_by(url: private_url)).to be_present++ sign_in(recipient)++ expect {+ post "/clicks/track",+ params: {+ url: private_url,+ post_id: private_message_post.id,+ topic_id: private_message_post.topic_id,+ },+ headers: headers+ }.to change { TopicLinkClick.count }.by(1)++ expect(response.status).to eq(200)+ expect(response.parsed_body["success"]).to eq("OK")+ end++ it "does not create a TopicLinkClick for a private message post the user cannot see" do+ private_url = "https://example.com/private-click-test"+ private_message_post =+ create_post(+ user: user,+ archetype: Archetype.private_message,+ target_usernames: [recipient.username],+ raw: "this private message has a link #{private_url}",+ )+ expect(private_message_post.topic_links.find_by(url: private_url)).to be_present++ sign_in(unauthorized_user)++ expect {+ post "/clicks/track",+ params: {+ url: private_url,+ post_id: private_message_post.id,+ topic_id: private_message_post.topic_id,+ },+ headers: headers+ }.not_to change { TopicLinkClick.count }++ expect(response.status).to eq(200)+ expect(response.parsed_body["success"]).to eq("OK")endendend