Skip to content

A platform for community discussion. Free, open, simple.

FIX: Dismiss buttons not showing in Horizon (#40326)

Martin Brennanb75ff1eaabe2
diff --git a/frontend/discourse/app/components/topic-dismiss-buttons.gjs b/frontend/discourse/app/components/topic-dismiss-buttons.gjs
index 0238d2eb137..9e57caef482 100644
--- a/frontend/discourse/app/components/topic-dismiss-buttons.gjs
+++ b/frontend/discourse/app/components/topic-dismiss-buttons.gjs
@@ -5,6 +5,7 @@ import DismissReadModal from "discourse/components/modal/dismiss-read";
import DButton from "discourse/ui-kit/d-button";
import DComboButton from "discourse/ui-kit/d-combo-button";
import DDropdownMenu from "discourse/ui-kit/d-dropdown-menu";
+import dConcatClass from "discourse/ui-kit/helpers/d-concat-class";
import { i18n } from "discourse-i18n";
export default class TopicDismissButtons extends Component {
@@ -128,7 +129,10 @@ export default class TopicDismissButtons extends Component {
{{~#if @showResetNew~}}
{{#if @showNewDismissCombo}}
<DComboButton
- class="--has-menu topic-dismiss-buttons__combo"
+ class={{dConcatClass
+ "topic-dismiss-buttons__combo"
+ (if this.showDismissNewMenu "--has-menu")
+ }}
as |combo|
>
<combo.Button
diff --git a/frontend/discourse/app/components/topic-drafts-dropdown.gjs b/frontend/discourse/app/components/topic-drafts-dropdown.gjs
index e571562521a..18bc9654a9d 100644
--- a/frontend/discourse/app/components/topic-drafts-dropdown.gjs
+++ b/frontend/discourse/app/components/topic-drafts-dropdown.gjs
@@ -12,6 +12,7 @@ import { or } from "discourse/truth-helpers";
import DButton from "discourse/ui-kit/d-button";
import DComboButton from "discourse/ui-kit/d-combo-button";
import DDropdownMenu from "discourse/ui-kit/d-dropdown-menu";
+import dConcatClass from "discourse/ui-kit/helpers/d-concat-class";
import { i18n } from "discourse-i18n";
const DRAFTS_LIMIT = 4;
@@ -99,7 +100,10 @@ export default class TopicDraftsDropdown extends Component {
<template>
<DComboButton
- class={{if @showDrafts "--has-menu"}}
+ class={{dConcatClass
+ "topic-create-button__combo"
+ (if @showDrafts "--has-menu")
+ }}
aria-label={{i18n "topic.create_group"}}
...attributes
as |combo|
diff --git a/themes/horizon/scss/hiddenstuff.scss b/themes/horizon/scss/hiddenstuff.scss
index 02df5087908..079cf1f2da2 100644
--- a/themes/horizon/scss/hiddenstuff.scss
+++ b/themes/horizon/scss/hiddenstuff.scss
@@ -10,7 +10,7 @@
@include viewport.from(md) {
.horizon-new-topic-button-enabled {
- .list-controls .d-combo-button {
+ .list-controls .topic-create-button__combo {
display: none;
}
}