Skip to content

A platform for community discussion. Free, open, simple.

UX: add i18n for new copy + remove unused placeholder (#40603)

chapoib7e299f8b970
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index bb216639e35..2c31b092080 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -8044,6 +8044,7 @@ en:
finish_install: "Finish Theme Installation"
last_attempt: "Installation process did not finish, last attempted:"
remote_branch: "Branch name (optional)"
+ remote_branch_placeholder: "Choose a specific branch or keep empty"
public_key: "Grant the following public key access to the repo:"
install: "Install"
installed: "Installed"
diff --git a/frontend/discourse/admin/components/modal/install-theme.gjs b/frontend/discourse/admin/components/modal/install-theme.gjs
index 162a2a63353..74f5f24e8ad 100644
--- a/frontend/discourse/admin/components/modal/install-theme.gjs
+++ b/frontend/discourse/admin/components/modal/install-theme.gjs
@@ -407,7 +407,6 @@ export default class InstallThemeModal extends Component {
type="text"
{{on "input" (withEventValue (fn (mut this.uploadUrl)))}}
value={{this.uploadUrl}}
- placeholder={{this.urlPlaceholder}}
/>
</div>
<DButton
@@ -424,7 +423,9 @@ export default class InstallThemeModal extends Component {
type="text"
{{on "input" (withEventValue (fn (mut this.branch)))}}
value={{this.branch}}
- placeholder="main"
+ placeholder={{i18n
+ "admin.customize.theme.remote_branch_placeholder"
+ }}
/>
</div>
{{/if}}