A platform for community discussion. Free, open, simple.
FEATURE: Also send composer title for category recommendation (#42842)
Natalie Tayb7e937799009
diff --git a/plugins/discourse-ai/assets/javascripts/discourse/initializers/ai-category-chooser-inline-suggester.js b/plugins/discourse-ai/assets/javascripts/discourse/initializers/ai-category-chooser-inline-suggester.jsindex bec5282ebc2..ead98f8b5f1 100644--- a/plugins/discourse-ai/assets/javascripts/discourse/initializers/ai-category-chooser-inline-suggester.js+++ b/plugins/discourse-ai/assets/javascripts/discourse/initializers/ai-category-chooser-inline-suggester.js@@ -112,7 +112,7 @@ function initInlineCategorySuggester(api) {return;}- if (!stateFor(component).loading && context.available) {+ if (!stateFor(component).loading && context.categoryAvailable) {return triggerRow(component, context);}});diff --git a/plugins/discourse-ai/assets/javascripts/discourse/lib/chooser-suggestion-context.js b/plugins/discourse-ai/assets/javascripts/discourse/lib/chooser-suggestion-context.jsindex 64c005bfc22..df671695a24 100644--- a/plugins/discourse-ai/assets/javascripts/discourse/lib/chooser-suggestion-context.js+++ b/plugins/discourse-ai/assets/javascripts/discourse/lib/chooser-suggestion-context.js@@ -31,11 +31,20 @@ class ComposerSuggestionContext {return (this.model?.reply?.length ?? 0) > MIN_CHARACTER_COUNT;}+ get categoryAvailable() {+ return Boolean(this.model?.title?.trim()) || this.available;+ }+categoryRequestData() {- const text = this.model?.reply;- if (!text || text.length < MIN_CHARACTER_COUNT) {+ if (!this.categoryAvailable) {return null;}++ const text = [this.model?.title, this.model?.reply]+ .map((part) => part?.trim())+ .filter(Boolean)+ .join("\n\n");+return { text };}@@ -77,6 +86,10 @@ class EditTopicSuggestionContext {return true;}+ get categoryAvailable() {+ return true;+ }+categoryRequestData() {return { topic_id: this.topicController.model.id };}diff --git a/plugins/discourse-ai/test/javascripts/unit/lib/chooser-suggestion-context-test.js b/plugins/discourse-ai/test/javascripts/unit/lib/chooser-suggestion-context-test.jsnew file mode 100644index 00000000000..2f1261ef07c--- /dev/null+++ b/plugins/discourse-ai/test/javascripts/unit/lib/chooser-suggestion-context-test.js@@ -0,0 +1,40 @@+import { setOwner } from "@ember/owner";+import { setupTest } from "ember-qunit";+import { module, test } from "qunit";+import { chooserSuggestionContext } from "discourse/plugins/discourse-ai/discourse/lib/chooser-suggestion-context";++module("Unit | Lib | chooser-suggestion-context", function (hooks) {+ setupTest(hooks);++ test("uses a new topic title when suggesting a category", function (assert) {+ this.owner.register(+ "service:composer",+ {+ model: {+ title: "How do I catch a Pokémon?",+ reply: "",+ },+ },+ { instantiate: false }+ );++ const component = {+ element: {+ closest: (selector) => selector === "#reply-control",+ },+ };+ setOwner(component, this.owner);++ const context = chooserSuggestionContext(component);++ assert.true(+ context.categoryAvailable,+ "category suggestions are available"+ );+ assert.deepEqual(+ context.categoryRequestData(),+ { text: "How do I catch a Pokémon?" },+ "the title is sent for categorization"+ );+ });+});