A platform for community discussion. Free, open, simple.
SECURITY: Block post iframes whose encoded userinfo bypasses the allowed_iframes allowlist
Isaac Janzenbac7dd120191
diff --git a/frontend/pretty-text/addon/sanitizer.js b/frontend/pretty-text/addon/sanitizer.jsindex c9a8220526c..fe147f719e8 100644--- a/frontend/pretty-text/addon/sanitizer.js+++ b/frontend/pretty-text/addon/sanitizer.js@@ -138,6 +138,8 @@ export function sanitize(text, allowLister) {} catch {return false;}+ const iframeUrls = [decoded];+ iframeUrls.push(value);return (!decoded.match(/\/\.+\//) &&allowedIframes.some((i) => {@@ -145,7 +147,10 @@ export function sanitize(text, allowLister) {// escape regex, keeping *.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, "[^/]+");- return new RegExp(`^${regex}.*$`, "i").test(decoded);+ const allowedIframe = new RegExp(`^${regex}.*$`, "i");+ return iframeUrls.every((iframeUrl) =>+ allowedIframe.test(iframeUrl)+ );}));})())diff --git a/spec/requests/posts_controller_spec.rb b/spec/requests/posts_controller_spec.rbindex 6891ec7084b..b8ca87dd3b1 100644--- a/spec/requests/posts_controller_spec.rb+++ b/spec/requests/posts_controller_spec.rb@@ -2271,6 +2271,25 @@ RSpec.describe PostsController doendend+ it "does not persist an iframe whose encoded userinfo points to an unallowlisted host" do+ iframe_source = "https://www.instagram.com%[email protected]/"++ post "/posts.json",+ params: {+ raw: %(User content <iframe src="#{iframe_source}"></iframe>),+ title: "Iframe allowlist bypass",+ }++ created_post = Post.find(response.parsed_body["id"])++ aggregate_failures do+ expect(response.status).to eq(200)+ expect(response.body).to include(%("id":#{created_post.id}))+ expect(created_post.cooked).not_to include(iframe_source)+ expect(Nokogiri::HTML5.fragment(created_post.cooked).at_css("iframe")).to be_nil+ end+ end+it "does not persist HTML from an untrusted oEmbed provider" doJobs.run_immediately!url = "https://attacker.example.com/onebox"