Skip to content

A platform for community discussion. Free, open, simple.

DEV: add isComplete to start posting options (#38764)

Gabriel Grubbabb16e3f67ad9
diff --git a/frontend/discourse/app/components/admin-onboarding/banner.gjs b/frontend/discourse/app/components/admin-onboarding/banner.gjs
index aa32203eca9..3feb7d44865 100644
--- a/frontend/discourse/app/components/admin-onboarding/banner.gjs
+++ b/frontend/discourse/app/components/admin-onboarding/banner.gjs
@@ -92,6 +92,7 @@ const STEPS = [
this.modal.show(StartPostingOptions, {
model: {
options,
+ isStepComplete: this.completed,
},
});
}
diff --git a/frontend/discourse/app/components/admin-onboarding/modal/start-posting-options.gjs b/frontend/discourse/app/components/admin-onboarding/modal/start-posting-options.gjs
index 78eb8235759..f4c83a1bbad 100644
--- a/frontend/discourse/app/components/admin-onboarding/modal/start-posting-options.gjs
+++ b/frontend/discourse/app/components/admin-onboarding/modal/start-posting-options.gjs
@@ -10,7 +10,10 @@ const StartPostingOptions = <template>
<:body>
<div class="modal-options">
{{#each @model.options as |Option|}}
- <Option @closeModal={{@closeModal}} />
+ <Option
+ @closeModal={{@closeModal}}
+ @isComplete={{@model.isStepComplete}}
+ />
{{/each}}
</div>
</:body>
diff --git a/frontend/discourse/app/components/admin-onboarding/start-posting-option.gjs b/frontend/discourse/app/components/admin-onboarding/start-posting-option.gjs
index e3809779e95..65ff6de9abc 100644
--- a/frontend/discourse/app/components/admin-onboarding/start-posting-option.gjs
+++ b/frontend/discourse/app/components/admin-onboarding/start-posting-option.gjs
@@ -33,6 +33,7 @@ export default class StartPostingOption extends Component {
{{i18n this.body}}
</p>
<DButton
+ @disabled={{this.disabled}}
@label={{this.actionLabel}}
@action={{this.onSelect}}
class="btn-default"
diff --git a/frontend/discourse/tests/acceptance/admin-onboarding-banner-test.gjs b/frontend/discourse/tests/acceptance/admin-onboarding-banner-test.gjs
index 27e899b7a4f..99304400b39 100644
--- a/frontend/discourse/tests/acceptance/admin-onboarding-banner-test.gjs
+++ b/frontend/discourse/tests/acceptance/admin-onboarding-banner-test.gjs
@@ -135,6 +135,69 @@ acceptance("Admin - Onboarding Banner", function (needs) {
step.isChecked();
});
+ test("registered posting-option can disable its button when step is complete", async function (assert) {
+ withPluginApi((api) => {
+ api.registerValueTransformer(
+ "admin-onboarding-start-posting-options",
+ ({ value }) => {
+ value.push(
+ class CompletingOption extends StartPostingOption {
+ @service appEvents;
+
+ name = "completing-option";
+ title = "admin_onboarding_banner.start_posting.extra_option";
+ body =
+ "admin_onboarding_banner.start_posting.extra_option_description";
+ actionLabel = "admin_onboarding_banner.start_posting.use_extra";
+
+ @action
+ onSelect() {
+ this.appEvents.trigger("admin-onboarding:posting-complete");
+ this.args.closeModal();
+ }
+ }
+ );
+
+ value.push(
+ class DisableableOption extends StartPostingOption {
+ name = "disableable-option";
+ title = "admin_onboarding_banner.start_posting.extra_option";
+ body =
+ "admin_onboarding_banner.start_posting.extra_option_description";
+ actionLabel = "admin_onboarding_banner.start_posting.use_extra";
+
+ get disabled() {
+ return this.args.isComplete;
+ }
+
+ @action
+ onSelect() {}
+ }
+ );
+
+ return value;
+ }
+ );
+ });
+
+ await visit("/");
+
+ await withStep("start_posting", assert).clickAction();
+
+ assert.dom(".option").exists({ count: 3 });
+ assert
+ .dom(".disableable-option .btn")
+ .isNotDisabled("button is enabled before step completion");
+
+ await click(".completing-option .btn");
+
+ await withStep("start_posting", assert).clickAction();
+
+ assert
+ .dom(".disableable-option .btn")
+ .isDisabled("button is disabled after step completion");
+ });
+
test("it can complete `invite_collaborators` step", async function (assert) {
const step = withStep("invite_collaborators", assert);
await visit("/");