Skip to content

A platform for community discussion. Free, open, simple.

FIX: Parse Amazon product IDs after slugs ending in "dp"

Régis Hanolbc001dced113
diff --git a/lib/onebox/engine/amazon_onebox.rb b/lib/onebox/engine/amazon_onebox.rb
index 4ba2f9736a4..f7454353a53 100644
--- a/lib/onebox/engine/amazon_onebox.rb
+++ b/lib/onebox/engine/amazon_onebox.rb
@@ -39,7 +39,7 @@ module Onebox
private
def asin
- @asin ||= @url[%r{[dg]p/(?:product/|video/detail/)?([A-Z0-9]+)(?:[/?]|$)}i, 1]
+ @asin ||= @url[%r{/[dg]p/(?:product/|video/detail/)?([A-Z0-9]+)(?:[/?]|$)}i, 1]
end
def raw
diff --git a/spec/lib/onebox/engine/amazon_onebox_spec.rb b/spec/lib/onebox/engine/amazon_onebox_spec.rb
index f4b3dfd4d87..a0b02fb9a0c 100644
--- a/spec/lib/onebox/engine/amazon_onebox_spec.rb
+++ b/spec/lib/onebox/engine/amazon_onebox_spec.rb
@@ -29,6 +29,8 @@ RSpec.describe Onebox::Engine::AmazonOnebox do
"http://www.amazon.fr/gp/product/B01BYD0TZM" => "https://www.amazon.fr/dp/B01BYD0TZM",
"https://www.amazon.ca/gp/product/B087Z3N428?pf_rd_r=SXABADD0ZZ3NF9Q5F8TW&ref_=pd_gw_unk" =>
"https://www.amazon.ca/dp/B087Z3N428",
+ "https://www.amazon.com/Anker-USB-C-HDP/dp/B0CK8TKV5Z" =>
+ "https://www.amazon.com/dp/B0CK8TKV5Z",
}.each do |link, url|
expect(Onebox::Matcher.new(link).oneboxed).to eq(described_class)
expect(described_class.new(link).url).to eq(url)