A platform for community discussion. Free, open, simple.
SECURITY: Prevent topic existence disclosure in profile featuring (#42235)
Gabriel Grubbabe1c355de12f
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rbindex 823f1f6a589..956cf479d0c 100644--- a/app/controllers/users_controller.rb+++ b/app/controllers/users_controller.rb@@ -1901,7 +1901,8 @@ class UsersController < ApplicationControllerdef feature_topicuser = fetch_user_from_params- topic = Topic.find(params[:topic_id].to_i)+ topic = Topic.find_by(id: params[:topic_id].to_i)+ raise Discourse::NotFound unless guardian.can_see?(topic)if !guardian.can_feature_topic?(user, topic)return(diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rbindex cb183127502..6470905b8b6 100644--- a/spec/requests/users_controller_spec.rb+++ b/spec/requests/users_controller_spec.rb@@ -7552,6 +7552,18 @@ RSpec.describe UsersController doexpect(response.status).to eq(403)end+ it "returns not found for missing and inaccessible topics" do+ sign_in(user1)++ put "/u/#{user1.username}/feature-topic.json", params: { topic_id: private_message.id }+ expect(response.status).to eq(404)+ expect(response.parsed_body["error_type"]).to eq("not_found")++ put "/u/#{user1.username}/feature-topic.json", params: { topic_id: Topic.maximum(:id) + 1 }+ expect(response.status).to eq(404)+ expect(response.parsed_body["error_type"]).to eq("not_found")+ end+it "returns an error if the topic is not visible" dosign_in(user1)topic.update_status("visible", false, user1)@@ -7559,14 +7571,27 @@ RSpec.describe UsersController doexpect(response.status).to eq(403)end- it "returns an error if the topic's category is read_restricted" do+ it "returns an error if the user can see the topic's read-restricted category" dosign_in(user1)- category.set_permissions({})+ group = Fabricate(:group)+ group.add(user1)+ category.set_permissions(group => :readonly)+ category.save!topic.update(category_id: category.id)- put "/u/#{another_user.username}/feature-topic.json", params: { topic_id: topic.id }+ put "/u/#{user1.username}/feature-topic.json", params: { topic_id: topic.id }expect(response.status).to eq(403)end+ it "returns not found if the user cannot see the topic's category" do+ sign_in(user1)+ category.set_permissions(staff: :full)+ category.save!+ topic.update(category_id: category.id)+ put "/u/#{user1.username}/feature-topic.json", params: { topic_id: topic.id }+ expect(response.status).to eq(404)+ expect(response.parsed_body["error_type"]).to eq("not_found")+ end+it "sets featured_topic correctly for user created topic" dosign_in(user1)topic.update(user_id: user1.id)