A platform for community discussion. Free, open, simple.
SECURITY: Missing post-level authorization allows whisper metadata disclosure
Isaac Janzenbf8dbf6155ae
diff --git a/app/controllers/post_readers_controller.rb b/app/controllers/post_readers_controller.rbindex a6ff0a1f5e1..1d5f0a819e8 100644--- a/app/controllers/post_readers_controller.rb+++ b/app/controllers/post_readers_controller.rb@@ -5,6 +5,7 @@ class PostReadersController < ApplicationControllerdef indexpost = Post.includes(topic: %i[topic_allowed_groups topic_allowed_users]).find(params[:id])+ guardian.ensure_can_see!(post)ensure_can_see_readers!(post)readers =diff --git a/spec/requests/post_readers_controller_spec.rb b/spec/requests/post_readers_controller_spec.rbindex 83f26f94d12..38251ab4eb8 100644--- a/spec/requests/post_readers_controller_spec.rb+++ b/spec/requests/post_readers_controller_spec.rb@@ -130,5 +130,21 @@ RSpec.describe PostReadersController doexpect(response).to be_forbiddenend++ it "returns forbidden when a non-staff group member requests readers for a whisper post" do+ regular_user = Fabricate(:user)+ @group.update!(publish_read_state: true)+ @group.add(regular_user)+ sign_in(regular_user)++ @post.update!(post_type: Post.types[:whisper])+ staff_reader = Fabricate(:admin)+ @group.add(staff_reader)+ TopicUser.create!(user: staff_reader, topic: @group_message, last_read_post_number: 4)++ get "/post_readers.json", params: { id: @post.id }++ expect(response).to be_forbidden+ endendend