A platform for community discussion. Free, open, simple.
FIX: Hidden post excerpts can appear in public BestPosts rewinds (#40146)
Samc2315de8d0eb
diff --git a/plugins/discourse-rewind/app/services/discourse_rewind/action/best_posts.rb b/plugins/discourse-rewind/app/services/discourse_rewind/action/best_posts.rbindex fe723f5c869..bd2e76b04a9 100644--- a/plugins/discourse-rewind/app/services/discourse_rewind/action/best_posts.rb+++ b/plugins/discourse-rewind/app/services/discourse_rewind/action/best_posts.rb@@ -38,6 +38,7 @@ module DiscourseRewindbest_posts =Post.public_posts+ .visible.joins(topic: :category).where(user_id: user.id).where(posts: { created_at: date, deleted_at: nil })diff --git a/plugins/discourse-rewind/spec/actions/best_posts_spec.rb b/plugins/discourse-rewind/spec/actions/best_posts_spec.rbindex 515d4e89376..3af81d8eb26 100644--- a/plugins/discourse-rewind/spec/actions/best_posts_spec.rb+++ b/plugins/discourse-rewind/spec/actions/best_posts_spec.rb@@ -100,6 +100,42 @@ RSpec.describe DiscourseRewind::Action::BestPosts doendend+ context "when public content is hidden from normal viewers" do+ fab!(:public_category, :category)+ fab!(:hidden_post_topic) { Fabricate(:topic, user: user, category: public_category) }+ fab!(:hidden_post) do+ Fabricate(+ :post,+ created_at: random_datetime,+ user: user,+ post_number: 2,+ topic: hidden_post_topic,+ hidden: true,+ like_count: 99,+ )+ end+ fab!(:unlisted_topic) do+ Fabricate(:topic, user: user, category: public_category, visible: false)+ end+ fab!(:unlisted_topic_post) do+ Fabricate(+ :post,+ created_at: random_datetime,+ user: user,+ post_number: 2,+ topic: unlisted_topic,+ like_count: 98,+ )+ end++ it "does not include hidden posts or posts in unlisted topics" do+ topic_ids = call_report[:data].map { |d| d[:topic_id] }++ expect(topic_ids).not_to include(hidden_post_topic.id)+ expect(topic_ids).not_to include(unlisted_topic.id)+ end+ end+context "when a post is a whisper" dofab!(:whisper_post) doFabricate(