Skip to content

A platform for community discussion. Free, open, simple.

DEV: Don't trigger `DMenuInstance`'s `onClose` twice (#40045)

Jarek Radoszc429447de1f2
diff --git a/frontend/discourse/float-kit/lib/d-menu-instance.js b/frontend/discourse/float-kit/lib/d-menu-instance.js
index 730630b5014..1b5b4900145 100644
--- a/frontend/discourse/float-kit/lib/d-menu-instance.js
+++ b/frontend/discourse/float-kit/lib/d-menu-instance.js
@@ -74,8 +74,6 @@ export default class DMenuInstance extends FloatKitInstance {
await animateClosing(this.content);
- await super.close(...arguments);
-
if (this.site.mobileView && this.options.modalForMobile && this.expanded) {
await this.modal.close();
}
@@ -86,7 +84,7 @@ export default class DMenuInstance extends FloatKitInstance {
this.trigger?.focus?.();
}
- await this.options.onClose?.(this);
+ await super.close(...arguments);
}
@action