Skip to content

A platform for community discussion. Free, open, simple.

DEV: Don't leak composer mesages cache between tests (#39567)

Jarek Radoszc81ee13d0029
diff --git a/frontend/discourse/app/components/composer-messages.gjs b/frontend/discourse/app/components/composer-messages.gjs
index 1e13fc0f9c7..200bc438bb5 100644
--- a/frontend/discourse/app/components/composer-messages.gjs
+++ b/frontend/discourse/app/components/composer-messages.gjs
@@ -21,6 +21,10 @@ import { autoTrackedArray } from "../lib/tracked-tools";
let _messagesCache = {};
+export function resetComposerMessagesCache() {
+ _messagesCache = {};
+}
+
@tagName("")
export default class ComposerMessages extends Component {
@tracked showShareModal;
diff --git a/frontend/discourse/tests/helpers/qunit-helpers.js b/frontend/discourse/tests/helpers/qunit-helpers.js
index 6bc894dbdbc..0567f2c388b 100644
--- a/frontend/discourse/tests/helpers/qunit-helpers.js
+++ b/frontend/discourse/tests/helpers/qunit-helpers.js
@@ -22,6 +22,7 @@ import {
cleanUpComposerUploadMarkdownResolver,
cleanUpComposerUploadPreProcessor,
} from "discourse/components/composer-editor";
+import { resetComposerMessagesCache } from "discourse/components/composer-messages";
import { clearPluginDocumentTitleCounters } from "discourse/components/d-document";
import { clearToolbarCallbacks } from "discourse/components/d-editor";
import { resetHtmlDecorators } from "discourse/components/decorated-html";
@@ -233,6 +234,7 @@ export function testCleanup(container, app) {
cleanUpComposerUploadHandler();
cleanUpComposerUploadMarkdownResolver();
cleanUpComposerUploadPreProcessor();
+ resetComposerMessagesCache();
clearTopicFooterDropdowns();
clearTopicFooterButtons();
clearDesktopNotificationHandlers();