Skip to content

A platform for community discussion. Free, open, simple.

UX: Match filter dropdowns to the height and border of other inputs (#45398)

David Battersbyc9ecda4be577
diff --git a/app/assets/stylesheets/common/components/d-filter-controls.scss b/app/assets/stylesheets/common/components/d-filter-controls.scss
index e0fa6587eaf..661a39af17e 100644
--- a/app/assets/stylesheets/common/components/d-filter-controls.scss
+++ b/app/assets/stylesheets/common/components/d-filter-controls.scss
@@ -43,6 +43,8 @@
&__dropdown {
flex: 1 1 auto;
+ height: auto;
+ min-height: 2.25em;
&.--active {
border-color: var(--tertiary);
diff --git a/app/assets/stylesheets/common/components/d-native-select.scss b/app/assets/stylesheets/common/components/d-native-select.scss
index b996ec74c52..d9e990324c1 100644
--- a/app/assets/stylesheets/common/components/d-native-select.scss
+++ b/app/assets/stylesheets/common/components/d-native-select.scss
@@ -1,8 +1,8 @@
.d-native-select {
width: 100%;
height: 2.25em;
- background: var(--secondary);
- border: 1px solid var(--primary-400);
+ background: var(--token-color-background-input);
+ border: var(--d-input-border);
border-radius: var(--d-input-border-radius);
box-sizing: border-box;
margin: 0;
@@ -24,7 +24,7 @@
&:active {
// these `!important` flags are another great case for having a button element without that pesky default styling
&:not(:disabled) {
- background-color: var(--secondary) !important;
+ background-color: var(--token-color-background-input) !important;
color: var(--primary) !important;
border-color: var(--tertiary);
outline: 2px solid var(--tertiary);
@@ -38,7 +38,7 @@
&:hover:not(:disabled) {
.discourse-no-touch & {
- background-color: var(--secondary);
+ background-color: var(--token-color-background-input);
color: var(--primary);
border-color: var(--tertiary);