A platform for community discussion. Free, open, simple.
SECURITY: Stored XSS in discourse-ai shared conversations onebox
Isaac Janzencac7d618a562
diff --git a/plugins/discourse-ai/spec/models/shared_ai_conversation_spec.rb b/plugins/discourse-ai/spec/models/shared_ai_conversation_spec.rbindex bd31eb6afcb..bad7d82e683 100644--- a/plugins/discourse-ai/spec/models/shared_ai_conversation_spec.rb+++ b/plugins/discourse-ai/spec/models/shared_ai_conversation_spec.rb@@ -116,6 +116,16 @@ RSpec.describe SharedAiConversation, type: :model doexpect(onebox).not_to include("</marquee>")expect(onebox).to include("AI Conversation with Claude-2")end++ it "escapes HTML in the title to prevent XSS" do+ conversation = described_class.share_conversation(user, topic)+ xss_title = "<img src=x onerror=alert(1)>"+ conversation.update!(title: xss_title)+ onebox = conversation.onebox++ expect(onebox).not_to include(xss_title)+ expect(onebox).to include(ERB::Util.html_escape(xss_title))+ endenddescribe "#onebox" do