A platform for community discussion. Free, open, simple.
FIX: Prevent deletion of system badges via the admin API (#42452)
Gabriel Grubbacb34503b9d35
diff --git a/app/controllers/admin/badges_controller.rb b/app/controllers/admin/badges_controller.rbindex d2457467c9d..ba186a7479e 100644--- a/app/controllers/admin/badges_controller.rb+++ b/app/controllers/admin/badges_controller.rb@@ -168,8 +168,11 @@ class Admin::BadgesController < Admin::AdminControllerenddef destroy+ badge = find_badge++ return render_json_error(I18n.t("badges.errors.cant_delete_system_badge")) if badge.system?+Badge.transaction do- badge = find_badgeStaffActionLogger.new(current_user).log_badge_deletion(badge)badge.clear_user_titles!badge.destroy!diff --git a/config/locales/server.en.yml b/config/locales/server.en.ymlindex cbe952c3699..b92fcfb72a9 100644--- a/config/locales/server.en.yml+++ b/config/locales/server.en.yml@@ -5634,6 +5634,8 @@ en:This document is CC-BY-SA. It was last updated [INSERT LAST UPDATE DATE HERE].badges:+ errors:+ cant_delete_system_badge: System badges cannot be deleted.mass_award:errors:invalid_csv: We encountered an error on line %{line_number}. Please confirm the CSV has one email per line.diff --git a/spec/requests/admin/badges_controller_spec.rb b/spec/requests/admin/badges_controller_spec.rbindex fc16a55bb63..33422290c5e 100644--- a/spec/requests/admin/badges_controller_spec.rb+++ b/spec/requests/admin/badges_controller_spec.rb@@ -273,6 +273,32 @@ RSpec.describe Admin::BadgesController docontext "when logged in as an admin" dobefore { sign_in(admin) }+ it "prevents deletion of system badges" do+ system_badge = Badge.find(Badge::Regular)+ expect(system_badge.system?).to eq(true)++ user_badge = BadgeGranter.grant(system_badge, user)+ user.update!(title: system_badge.name)+ user.user_profile.update!(granted_title_badge_id: system_badge.id)++ delete "/admin/badges/#{system_badge.id}.json"++ expect(response.status).to eq(422)+ expect(response.parsed_body["errors"]).to include(+ I18n.t("badges.errors.cant_delete_system_badge"),+ )+ expect(Badge.where(id: system_badge.id)).to exist+ expect(UserBadge.where(id: user_badge.id)).to exist+ expect(user.reload.title).to eq(system_badge.name)+ expect(user.user_profile.reload.granted_title_badge_id).to eq(system_badge.id)+ expect(+ UserHistory.where(+ acting_user_id: admin.id,+ action: UserHistory.actions[:delete_badge],+ ).exists?,+ ).to eq(false)+ end+it "deletes the badge" dodelete "/admin/badges/#{badge.id}.json"expect(response.status).to eq(200)