A platform for community discussion. Free, open, simple.
FIX: Avoid duplicate category updated events (#42406)
Natalie Taycb5b167333b1
diff --git a/app/controllers/categories_controller.rb b/app/controllers/categories_controller.rbindex 7d7f1fb478b..aff4afe2094 100644--- a/app/controllers/categories_controller.rb+++ b/app/controllers/categories_controller.rb@@ -315,8 +315,6 @@ class CategoriesController < ApplicationControllerendend- DiscourseEvent.trigger(:category_updated, cat) if result-resultendenddiff --git a/spec/requests/categories_controller_spec.rb b/spec/requests/categories_controller_spec.rbindex 2036e51b453..7f65a75f15e 100644--- a/spec/requests/categories_controller_spec.rb+++ b/spec/requests/categories_controller_spec.rb@@ -495,21 +495,21 @@ RSpec.describe CategoriesController dodescribe "extensibility event" dobefore { sign_in(admin) }- it "triggers a extensibility event" do- event =- DiscourseEvent- .track_events do- put "/categories/#{category.id}.json",- params: {- name: "hello",- color: "ff0",- text_color: "fff",- }- end- .last+ it "triggers the category updated event once" do+ events =+ DiscourseEvent.track_events do+ put "/categories/#{category.id}.json",+ params: {+ name: "hello",+ color: "ff0",+ text_color: "fff",+ }+ end++ category_updated_events = events.select { |event| event[:event_name] == :category_updated }- expect(event[:event_name]).to eq(:category_updated)- expect(event[:params].first).to eq(category)+ expect(category_updated_events.size).to eq(1)+ expect(category_updated_events.pluck(:params).map(&:first)).to all(eq(category))endend