A platform for community discussion. Free, open, simple.
FIX: Anonymous MessageBus clients receive admin-only Workflow node metadata (#41921)
Isaac Janzencd4afb14a42f
diff --git a/plugins/discourse-workflows/app/services/discourse_workflows/workflow/update_pin_data.rb b/plugins/discourse-workflows/app/services/discourse_workflows/workflow/update_pin_data.rbindex 3b759ee2c25..73e1be2fcf1 100644--- a/plugins/discourse-workflows/app/services/discourse_workflows/workflow/update_pin_data.rb+++ b/plugins/discourse-workflows/app/services/discourse_workflows/workflow/update_pin_data.rb@@ -95,6 +95,7 @@ module DiscourseWorkflowspinned: !params.unpin?,pinned_node_names: workflow.pinned_node_names,},+ group_ids: [Group::AUTO_GROUPS[:admins]],)enddiff --git a/plugins/discourse-workflows/spec/requests/discourse_workflows/workflows_controller_spec.rb b/plugins/discourse-workflows/spec/requests/discourse_workflows/workflows_controller_spec.rbindex 7727a56dd03..37e9f18a937 100644--- a/plugins/discourse-workflows/spec/requests/discourse_workflows/workflows_controller_spec.rb+++ b/plugins/discourse-workflows/spec/requests/discourse_workflows/workflows_controller_spec.rb@@ -405,6 +405,42 @@ RSpec.describe DiscourseWorkflows::WorkflowsController doexpect(response).to have_http_status(:no_content)expect(workflow.reload.pin_data).not_to have_key("Trigger-1")end++ it "does not expose pin metadata to anonymous MessageBus clients" do+ channel = "/discourse-workflows/workflows/#{workflow.id}/pin_data"+ last_message_id = MessageBus.last_id(channel)+ node_name = workflow.nodes.first["name"]++ put "/admin/plugins/discourse-workflows/workflows/#{workflow.id}/pin-data.json",+ params: {+ node_name: node_name,+ items: [{ json: { private_sample: true } }],+ },+ as: :json++ expect(response).to have_http_status(:no_content)++ delete "/session/#{admin.username}.json", xhr: true+ expect(response).to have_http_status(:ok)++ get "/admin/plugins/discourse-workflows/workflows/#{workflow.id}.json"+ expect(response).to have_http_status(:not_found)++ post "/message-bus/#{SecureRandom.hex}/poll",+ params: {+ channel => last_message_id,+ },+ headers: {+ "HTTP_DONT_CHUNK" => "true",+ },+ as: :json++ expect(response).to have_http_status(:ok)+ expect(response.parsed_body).to contain_exactly(+ include("channel" => "/__status", "data" => { channel => MessageBus.last_id(channel) }),+ )+ expect(response.body).not_to include(node_name)+ endenddescribe "POST /admin/plugins/discourse-workflows/workflows/:id/discard-draft" do