A platform for community discussion. Free, open, simple.
FIX: Bump topic when auto-responding to flag dispositions (#39156)
Régis HANOLcf5cd2dccde5
diff --git a/app/models/post_action.rb b/app/models/post_action.rbindex 226420de276..977d85620f9 100644--- a/app/models/post_action.rb+++ b/app/models/post_action.rb@@ -102,7 +102,7 @@ class PostAction < ActiveRecord::Basemessage_key << "_and_deleted" if delete_postI18n.with_locale(SiteSetting.default_locale) do- related_post.topic.add_moderator_post(moderator, I18n.t(message_key))+ related_post.topic.add_moderator_post(moderator, I18n.t(message_key), bump: true)end# archive message for moderatorsdiff --git a/spec/models/post_action_spec.rb b/spec/models/post_action_spec.rbindex bfaf9e88982..d50b17d3aca 100644--- a/spec/models/post_action_spec.rb+++ b/spec/models/post_action_spec.rb@@ -898,6 +898,23 @@ RSpec.describe PostAction doexpect(user_notifications.last.topic).to eq(topic)end+ %i[agree_and_keep disagree ignore_and_do_nothing].each do |disposition|+ it "should bump the topic when performing #{disposition}" do+ SiteSetting.auto_respond_to_flag_actions = true+ user = Fabricate(:user, refresh_auto_groups: true)+ result = PostActionCreator.create(user, post, :spam, message: "WAT")+ topic = result.post_action.related_post.topic++ original_bumped_at = topic.reload.bumped_at++ freeze_time 1.hour.from_now++ result.reviewable.perform(admin, disposition)++ expect(topic.reload.bumped_at).to be > original_bumped_at+ end+ end+skip "should not add a moderator post when post is flagged via private message" doJobs.run_immediately!user = Fabricate(:user)