A platform for community discussion. Free, open, simple.
FIX: Public post revision JSON exposes editor real names when names are disabled (#40021)
Samd4725b578f4b
diff --git a/app/serializers/post_revision_serializer.rb b/app/serializers/post_revision_serializer.rbindex 06651f4926b..725b0745aff 100644--- a/app/serializers/post_revision_serializer.rb+++ b/app/serializers/post_revision_serializer.rb@@ -104,6 +104,10 @@ class PostRevisionSerializer < ApplicationSerializeruser.nameend+ def include_acting_user_name?+ SiteSetting.enable_names?+ end+def avatar_templateuser.avatar_templateenddiff --git a/spec/requests/posts_controller_spec.rb b/spec/requests/posts_controller_spec.rbindex 9703dea5fb1..02925c7a854 100644--- a/spec/requests/posts_controller_spec.rb+++ b/spec/requests/posts_controller_spec.rb@@ -2690,6 +2690,19 @@ RSpec.describe PostsController doget "/posts/#{post_revision.post_id}/revisions/#{post_revision.number}.json"expect(response.status).to eq(200)end++ context "when names are disabled" do+ before { SiteSetting.enable_names = false }++ it "does not expose the acting user's name" do+ post_revision.user.update!(name: "Hidden Editor")++ get "/posts/#{post_revision.post_id}/revisions/#{post_revision.number}.json"++ expect(response.status).to eq(200)+ expect(response.parsed_body["acting_user_name"]).to eq(nil)+ end+ endendcontext "with deleted post" do