A platform for community discussion. Free, open, simple.
FIX: Match webhook-related messagebus audience to controller audience (#40693)
David Taylord47d27fc4c92
diff --git a/app/jobs/scheduled/redeliver_web_hook_events.rb b/app/jobs/scheduled/redeliver_web_hook_events.rbindex 09fd4cf745f..e6bf34a1c9f 100644--- a/app/jobs/scheduled/redeliver_web_hook_events.rb+++ b/app/jobs/scheduled/redeliver_web_hook_events.rb@@ -56,7 +56,7 @@ module Jobstype: type,web_hook_event: AdminWebHookEventSerializer.new(web_hook_event, root: false).as_json,},- group_ids: [Group::AUTO_GROUPS[:staff]],+ group_ids: [Group::AUTO_GROUPS[:admins]],)endenddiff --git a/spec/jobs/redeliver_web_hook_events_spec.rb b/spec/jobs/redeliver_web_hook_events_spec.rbindex 4d1b2d3be62..6de95165a1d 100644--- a/spec/jobs/redeliver_web_hook_events_spec.rb+++ b/spec/jobs/redeliver_web_hook_events_spec.rb@@ -43,7 +43,7 @@ RSpec.describe Jobs::RedeliverWebHookEvents doexpect(messages.first.data).to include(type: "redelivered")end- it "restricts the redelivery MessageBus publish to the staff group" do+ it "restricts the redelivery MessageBus publish to the admins group" dostub_request(:post, web_hook.payload_url).to_return(status: 200, body: "", headers: {})messages =@@ -54,7 +54,8 @@ RSpec.describe Jobs::RedeliverWebHookEvents doexpect(RedeliveringWebhookEvent.count).to eq(0)expect(messages.size).to eq(1)expect(messages.first.data).to include(type: "redelivered")- expect(messages.first.group_ids).to eq([Group::AUTO_GROUPS[:staff]])+ expect(messages.first.data[:web_hook_event]).to include(payload: "abc")+ expect(messages.first.group_ids).to eq([Group::AUTO_GROUPS[:admins]])endcontext "when there is a redelivering_webhook_event in process" do