Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Stored XSS in the video placeholder: sanitizeUrl does not reject double-quotes

Isaac Janzend7126af3264b
diff --git a/frontend/discourse/app/instance-initializers/video-placeholder.js b/frontend/discourse/app/instance-initializers/video-placeholder.js
index 52998acc6a4..0ff520d6e06 100644
--- a/frontend/discourse/app/instance-initializers/video-placeholder.js
+++ b/frontend/discourse/app/instance-initializers/video-placeholder.js
@@ -150,7 +150,8 @@ export default {
sanitized &&
sanitized.trim() !== "" &&
!sanitized.includes(">") &&
- !sanitized.includes("<")
+ !sanitized.includes("<") &&
+ !sanitized.includes('"')
) {
return sanitized;
}
diff --git a/frontend/discourse/tests/acceptance/video-placeholder-test.js b/frontend/discourse/tests/acceptance/video-placeholder-test.js
index d866ddd4610..b9064daf899 100644
--- a/frontend/discourse/tests/acceptance/video-placeholder-test.js
+++ b/frontend/discourse/tests/acceptance/video-placeholder-test.js
@@ -73,4 +73,26 @@ acceptance("Video Placeholder Test", function () {
.dom("video")
.doesNotExist("No video element is created for invalid URL");
});
+
+ test("displays an error for video URL with attribute breakout payload", async function (assert) {
+ await visit("/t/54081");
+
+ const placeholder = document.querySelector(".video-placeholder-container");
+ placeholder.setAttribute(
+ "data-video-src",
+ '/uploads/default/original/1X/video.mp4" onerror="window.__videoPlaceholderXss = true'
+ );
+
+ await click(".video-placeholder-overlay");
+
+ assert
+ .dom("[onerror]")
+ .doesNotExist("No event handler attribute is created");
+ assert
+ .dom("video")
+ .doesNotExist("No video element is created for invalid URL");
+ assert
+ .dom(".video-placeholder-wrapper .notice.error")
+ .exists("An error message is displayed for an invalid URL");
+ });
});