A platform for community discussion. Free, open, simple.
FIX: Save inline onebox URLs unescaped in the rich editor
Régis Hanold744b16a76b4
diff --git a/frontend/discourse/app/static/prosemirror/extensions/onebox.js b/frontend/discourse/app/static/prosemirror/extensions/onebox.jsindex 38ef28e9e06..32557aa2eca 100644--- a/frontend/discourse/app/static/prosemirror/extensions/onebox.js+++ b/frontend/discourse/app/static/prosemirror/extensions/onebox.js@@ -179,7 +179,7 @@ const extension = {state.write(" ");}- state.text(node.attrs.url);+ state.text(node.attrs.url, false);const nextSibling =parent.childCount > index + 1 ? parent.child(index + 1) : null;diff --git a/frontend/discourse/tests/integration/components/prosemirror-editor/onebox-test.js b/frontend/discourse/tests/integration/components/prosemirror-editor/onebox-test.jsindex beb2ced1a18..495453f078f 100644--- a/frontend/discourse/tests/integration/components/prosemirror-editor/onebox-test.js+++ b/frontend/discourse/tests/integration/components/prosemirror-editor/onebox-test.js@@ -155,6 +155,23 @@ module(assert.strictEqual(toasts.activeToasts.length, 1);});+ test("saves an inline onebox URL unescaped", async function (assert) {+ const url = "http://www.example.com/~user/has-title.html";+ const [editor] = await setupRichEditor(assert, "see x here");+ const { view } = editor;++ view.dispatch(+ view.state.tr.replaceWith(+ 5,+ 6,+ view.state.schema.nodes.onebox_inline.create({ url, title: "Title" })+ )+ );+ await settled();++ assert.strictEqual(editor.value, `see ${url} here`);+ });+test("saves the bracket after a bare link unescaped", async function (assert) {pretender.get("/inline-onebox", () => [200,