Skip to content

A platform for community discussion. Free, open, simple.

FIX: Stabilize deferred topic pageview specs (#41313)

Alan Guo Xiang Tand74e8d2f2992
diff --git a/spec/system/request_tracker_spec.rb b/spec/system/request_tracker_spec.rb
index 9f5f4133e25..31237c1772c 100644
--- a/spec/system/request_tracker_spec.rb
+++ b/spec/system/request_tracker_spec.rb
@@ -567,7 +567,7 @@ describe "Request tracking" do
it "tracks user viewing a topic correctly with deferred tracking" do
events =
- DiscourseEvent.track_events(:browser_pageview) do
+ DiscourseEvent.track_events(:browser_pageview) do |captured_events|
visit topic.url
try_until_success do
@@ -583,6 +583,9 @@ describe "Request tracking" do
logged_in_views: 1,
),
).to eq(true)
+ expect(
+ captured_events.any? { |event| event[:event_name] == :browser_pageview },
+ ).to eq(true)
end
end
@@ -635,7 +638,7 @@ describe "Request tracking" do
context "when anonymous" do
it "tracks an anonymous user viewing a topic correctly with deferred tracking" do
events =
- DiscourseEvent.track_events(:browser_pageview) do
+ DiscourseEvent.track_events(:browser_pageview) do |captured_events|
visit topic.url
try_until_success do
@@ -649,6 +652,9 @@ describe "Request tracking" do
logged_in_views: 0,
),
).to eq(true)
+ expect(
+ captured_events.any? { |event| event[:event_name] == :browser_pageview },
+ ).to eq(true)
end
end