A platform for community discussion. Free, open, simple.
FIX: Group post responses expose full names when name display is disabled (#39961)
discourse-patch-triage[bot]d7dba2042d9a
diff --git a/app/serializers/group_post_serializer.rb b/app/serializers/group_post_serializer.rbindex ec2a87ec3a9..bca1ac7d093 100644--- a/app/serializers/group_post_serializer.rb+++ b/app/serializers/group_post_serializer.rb@@ -43,7 +43,7 @@ class GroupPostSerializer < ApplicationSerializerobject.topic.posts_countend- def include_user_long_name?+ def include_name?SiteSetting.enable_names?enddiff --git a/spec/requests/groups_controller_spec.rb b/spec/requests/groups_controller_spec.rbindex c49173c2bbf..9dd86838cd5 100644--- a/spec/requests/groups_controller_spec.rb+++ b/spec/requests/groups_controller_spec.rb@@ -678,6 +678,20 @@ RSpec.describe GroupsController doexpect(response.parsed_body["posts"].first["id"]).to eq(post.id)end+ it "does not include names when names are disabled" do+ SiteSetting.enable_names = false+ user.update!(name: "Hidden Full Name")+ sign_in(user)+ Fabricate(:post, user: user)++ get "/groups/#{group.name}/posts.json"++ expect(response.status).to eq(200)+ post_response = response.parsed_body["posts"].first+ expect(post_response["username"]).to eq(user.username)+ expect(post_response).not_to have_key("name")+ end+it "returns moderator actions" dosign_in(user)post = Fabricate(:post, user: user, post_type: Post.types[:moderator_action])