Skip to content

A platform for community discussion. Free, open, simple.

FIX: Resolve deleted topics when serializing posts for workflows

Régis Hanold975d625ded6
diff --git a/plugins/discourse-workflows/app/serializers/discourse_workflows/post_serializer.rb b/plugins/discourse-workflows/app/serializers/discourse_workflows/post_serializer.rb
index 7cb011de7f1..73b6e9e650c 100644
--- a/plugins/discourse-workflows/app/serializers/discourse_workflows/post_serializer.rb
+++ b/plugins/discourse-workflows/app/serializers/discourse_workflows/post_serializer.rb
@@ -40,7 +40,9 @@ module DiscourseWorkflows
end
def post_url
- object.url
+ return "/404" if topic.blank?
+
+ ::Post.url(topic.slug, topic.id, object.post_number)
end
def username
@@ -88,7 +90,10 @@ module DiscourseWorkflows
private
def topic
- @topic ||= object.topic
+ return @topic if defined?(@topic)
+
+ @topic =
+ object.topic || (::Topic.with_deleted.find_by(id: object.topic_id) if scope.is_staff?)
end
end
end