A platform for community discussion. Free, open, simple.
FIX: Include deleted content in the AI review queue
Régis Hanoldcdc04cd0f83
diff --git a/plugins/discourse-ai/lib/agents/tools/list_reviewables.rb b/plugins/discourse-ai/lib/agents/tools/list_reviewables.rbindex 60ac3733f53..57aad45122c 100644--- a/plugins/discourse-ai/lib/agents/tools/list_reviewables.rb+++ b/plugins/discourse-ai/lib/agents/tools/list_reviewables.rb@@ -110,9 +110,12 @@ module DiscourseAi)end- reviewables = relation.to_a+ rows =+ Reviewable.with_deleted_content do+ relation.map { |reviewable| serialize_reviewable(reviewable) }+ end- if reviewables.empty?+ if rows.empty?return({status: "success",@@ -122,8 +125,6 @@ module DiscourseAi)end- rows = reviewables.map { |r| serialize_reviewable(r) }-{status: "success",message: I18n.t("discourse_ai.ai_bot.list_reviewables.found", count: rows.size),@@ -158,13 +159,11 @@ module DiscourseAiresult[:available_actions] = available_action_ids(reviewable)case reviewable- when ReviewableFlaggedPost- serialize_flagged_post(result, reviewable)when ReviewableQueuedPostserialize_queued_post(result, reviewable)when ReviewableUserserialize_user(result, reviewable)- when ReviewablePost+ when ReviewableFlaggedPost, ReviewablePostserialize_post(result, reviewable)end@@ -194,16 +193,6 @@ module DiscourseAiactions.bundles.flat_map { |bundle| bundle.actions.map { |a| a.server_action } }end- def serialize_flagged_post(result, reviewable)- post = reviewable.post- return unless post-- result[:post_id] = post.id- result[:post_number] = post.post_number- result[:post_excerpt] = post.excerpt(300, strip_links: true, text_entities: true)- result[:topic_title] = post.topic&.title- end-def serialize_queued_post(result, reviewable)payload = reviewable.payload || {}result[:queued_title] = payload["title"]diff --git a/plugins/discourse-ai/spec/lib/agents/tools/list_reviewables_spec.rb b/plugins/discourse-ai/spec/lib/agents/tools/list_reviewables_spec.rbindex 783b81ab054..66c64f11373 100644--- a/plugins/discourse-ai/spec/lib/agents/tools/list_reviewables_spec.rb+++ b/plugins/discourse-ai/spec/lib/agents/tools/list_reviewables_spec.rb@@ -56,6 +56,26 @@ RSpec.describe DiscourseAi::Agents::Tools::ListReviewables doexpect(item[:post_id]).to eq(post.id)end+ it "includes the content and title of deleted posts and topics" do+ topic = post.topic+ post_reviewable =+ ReviewablePost.needs_review!(+ target: post,+ created_by: Discourse.system_user,+ reviewable_by_moderator: true,+ )+ post.trash!+ topic.trash!++ result = tool({}).invoke++ [flagged_reviewable, post_reviewable].each do |reviewable|+ item = result[:reviewables].find { |entry| entry[:id] == reviewable.id }+ expect(item[:post_excerpt]).to be_present+ expect(item[:topic_title]).to eq(topic.title)+ end+ end+it "filters by type" doresult = tool(type: "ReviewableUser").invoke