A platform for community discussion. Free, open, simple.
FIX: Fix bypass_bump parameter ignoring explicit false values (#38637)
Gabriel Grubbadce7b107ec9d
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rbindex 6369ec52a94..a4cdbbaf7f0 100644--- a/app/controllers/posts_controller.rb+++ b/app/controllers/posts_controller.rb@@ -262,9 +262,13 @@ class PostsController < ApplicationControllerif params.key?(:bypass_bump) || params[:post]&.key?(:bypass_bump)if guardian.can_update_bumped_at?- opts[:bypass_bump] = ActiveModel::Type::Boolean.new.cast(- params[:bypass_bump].presence || params.dig(:post, :bypass_bump),- )+ bypass_bump_value =+ if params.key?(:bypass_bump)+ params[:bypass_bump]+ else+ params.dig(:post, :bypass_bump)+ end+ opts[:bypass_bump] = ActiveModel::Type::Boolean.new.cast(bypass_bump_value)endenddiff --git a/spec/requests/posts_controller_spec.rb b/spec/requests/posts_controller_spec.rbindex 3d1cd29d294..d7cb7f32df7 100644--- a/spec/requests/posts_controller_spec.rb+++ b/spec/requests/posts_controller_spec.rb@@ -678,6 +678,21 @@ RSpec.describe PostsController doexpect(response.status).to eq(200)end+ it "respects top-level bypass_bump=false over nested bypass_bump=true" do+ expect {+ put "/posts/#{wiki_post.id}.json",+ params: {+ bypass_bump: false,+ post: {+ raw: "updated content",+ bypass_bump: true,+ },+ },+ as: :json+ }.to change { wiki_post.topic.reload.bumped_at }+ expect(response.status).to eq(200)+ end+it "bumps the topic when bypass_bump is not provided" doexpect {put "/posts/#{wiki_post.id}.json", params: { post: { raw: "updated content" } }