Skip to content

A platform for community discussion. Free, open, simple.

DEV: document unsilence behavior on disagree_and_restore for category moderators (#39998)

Juan David Martínez Cubillosdcfc79fde288
diff --git a/spec/models/reviewable_flagged_post_spec.rb b/spec/models/reviewable_flagged_post_spec.rb
index 1f7652e7dfd..77e79869bd7 100644
--- a/spec/models/reviewable_flagged_post_spec.rb
+++ b/spec/models/reviewable_flagged_post_spec.rb
@@ -530,6 +530,53 @@ RSpec.describe ReviewableFlaggedPost, type: :model do
assert_pm_creation_enqueued(reviewable.post.user_id, "flags_disagreed")
end
+
+ it "unsilences the user if they were silenced for the post" do
+ reviewable = Fabricate(:reviewable_flagged_post)
+ target_user = reviewable.post.user
+ reviewable.post.update(
+ hidden: true,
+ hidden_at: Time.zone.now,
+ hidden_reason_id: PostActionType.types[:spam],
+ )
+ UserSilencer.silence(target_user, moderator, post_id: reviewable.post.id)
+
+ expect(target_user.reload.silenced?).to eq(true)
+
+ reviewable.perform(moderator, :disagree_and_restore)
+
+ expect(target_user.reload.silenced?).to eq(false)
+ end
+
+ context "with category group moderator" do
+ fab!(:group)
+ fab!(:category_moderator) { Fabricate(:user, refresh_auto_groups: true) }
+
+ before do
+ SiteSetting.enable_category_group_moderation = true
+ group.add(category_moderator)
+ end
+
+ it "unsilences the user if they were silenced for a post in the moderated category" do
+ category = Fabricate(:category)
+ Fabricate(:category_moderation_group, category: category, group: group)
+
+ topic = Fabricate(:topic, category: category)
+ post = Fabricate(:post, topic: topic)
+ target_user = post.user
+
+ reviewable = PostActionCreator.spam(user, post).reviewable
+ post.update(hidden: true, hidden_at: Time.zone.now)
+ UserSilencer.silence(target_user, moderator, post_id: post.id)
+
+ expect(target_user.reload.silenced?).to eq(true)
+
+ reviewable.perform(category_moderator, :disagree_and_restore)
+
+ expect(post.reload.hidden?).to eq(false)
+ expect(target_user.reload.silenced?).to eq(false)
+ end
+ end
end
describe "recalculating the reviewable score" do