Skip to content

A platform for community discussion. Free, open, simple.

FEATURE: Add workflow filters to the review queue (#44296)

Gabriel Grubbadd1f1ab0dc17
diff --git a/plugins/discourse-workflows/config/locales/client.en.yml b/plugins/discourse-workflows/config/locales/client.en.yml
index c3b33fce1c0..b25e3530f43 100644
--- a/plugins/discourse-workflows/config/locales/client.en.yml
+++ b/plugins/discourse-workflows/config/locales/client.en.yml
@@ -20,6 +20,10 @@ en:
discourse_workflows_workflow_created: "Create workflow"
discourse_workflows_workflow_destroyed: "Delete workflow"
js:
+ review:
+ types:
+ discourse_workflows_workflow:
+ title: "Workflows"
discourse_ai:
features:
discourse_workflows:
diff --git a/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_post/v1.rb b/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_post/v1.rb
index 5078ff49c6c..cf7cc30b4e8 100644
--- a/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_post/v1.rb
+++ b/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_post/v1.rb
@@ -115,12 +115,20 @@ module DiscourseWorkflows
raise Discourse::InvalidAccess if !actor.guardian.can_see?(post)
reason = score_reason_for(exec_ctx, config["reason"])
+ context = DiscourseWorkflows.reviewable_score_context(exec_ctx.get_workflow.id)
reviewable =
if SPAM_FLAG_TYPES.include?(flag_type)
- flag_as_spam(post, actor, flag_type, reason)
+ flag_as_spam(post, actor, flag_type, reason, context)
else
- add_to_review_queue(post, actor, flag_type, reason, attribution_for(exec_ctx))
+ add_to_review_queue(
+ post,
+ actor,
+ flag_type,
+ reason,
+ attribution_for(exec_ctx),
+ context,
+ )
end
output(post, flag_type, reviewable)
@@ -139,7 +147,7 @@ module DiscourseWorkflows
parts.join("<br>")
end
- def flag_as_spam(post, actor, flag_type, reason)
+ def flag_as_spam(post, actor, flag_type, reason, context)
if !actor.guardian.post_can_act?(post, :spam)
raise_node_error!(I18n.t("discourse_workflows.errors.flag_post.cannot_flag"))
end
@@ -152,6 +160,7 @@ module DiscourseWorkflows
post,
PostActionType.types[:spam],
reason: reason,
+ context: context,
queue_for_review: true,
).perform
@@ -171,7 +180,7 @@ module DiscourseWorkflows
result.reviewable
end
- def add_to_review_queue(post, actor, flag_type, reason, attribution)
+ def add_to_review_queue(post, actor, flag_type, reason, attribution, context)
destroying = %w[review_delete review_delete_silence].include?(flag_type)
if destroying
@@ -190,23 +199,30 @@ module DiscourseWorkflows
reviewable_by_moderator: true,
)
- add_review_score(reviewable, actor, reason)
+ add_review_score(reviewable, actor, reason, context)
post.hide!(PostActionType.types[:notify_moderators]) if flag_type == "review_hide"
reviewable
end
- def add_review_score(reviewable, actor, reason)
+ def add_review_score(reviewable, actor, reason, context)
score_type = ReviewableScore.types[:needs_approval]
if reviewable.reviewable_scores.pending.exists?(
user_id: actor.id,
reviewable_score_type: score_type,
+ context: context,
)
return
end
- reviewable.add_score(actor, score_type, reason: reason, force_review: true)
+ reviewable.add_score(
+ actor,
+ score_type,
+ reason: reason,
+ context: context,
+ force_review: true,
+ )
end
def promote_pending_reviewable_to_flagged!(post)
diff --git a/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_user/v1.rb b/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_user/v1.rb
index 39e81a69e6c..048383eed63 100644
--- a/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_user/v1.rb
+++ b/plugins/discourse-workflows/lib/discourse_workflows/nodes/flag_user/v1.rb
@@ -119,7 +119,8 @@ module DiscourseWorkflows
potential_spam: false,
payload: reviewable_payload(user),
)
- score_added = add_review_score(reviewable, actor)
+ context = DiscourseWorkflows.reviewable_score_context(exec_ctx.get_workflow.id)
+ score_added = add_review_score(reviewable, actor, context)
add_provenance_note(exec_ctx, reviewable, actor, config["reason"])
output(
@@ -152,18 +153,25 @@ module DiscourseWorkflows
::ReviewableUser.payload_for(user)
end
- def add_review_score(reviewable, actor)
+ def add_review_score(reviewable, actor, context)
score_type = ::ReviewableScore.types[:needs_approval]
if reviewable.reviewable_scores.pending.exists?(
user_id: actor.id,
reviewable_score_type: score_type,
reason: SCORE_REASON,
+ context: context,
)
return false
end
- reviewable.add_score(actor, score_type, reason: SCORE_REASON, force_review: true)
+ reviewable.add_score(
+ actor,
+ score_type,
+ reason: SCORE_REASON,
+ context: context,
+ force_review: true,
+ )
true
end
diff --git a/plugins/discourse-workflows/plugin.rb b/plugins/discourse-workflows/plugin.rb
index 41c39fd7b8e..d3a84c7a574 100644
--- a/plugins/discourse-workflows/plugin.rb
+++ b/plugins/discourse-workflows/plugin.rb
@@ -12,6 +12,10 @@ enabled_site_setting :enable_discourse_workflows
module ::DiscourseWorkflows
PLUGIN_NAME = "discourse-workflows"
TEMPLATES_PATH = File.expand_path("config/templates", __dir__)
+
+ def self.reviewable_score_context(workflow_id)
+ "discourse_workflows:workflow:#{workflow_id}" if workflow_id.present?
+ end
end
require_relative "lib/discourse_workflows/engine"
@@ -66,6 +70,40 @@ DiscoursePluginRegistry.define_filtered_register(:discourse_workflows_credential
after_initialize do
Rails.application.config.filter_parameters += %i[signature]
+ add_custom_reviewable_filter(
+ [
+ :workflow_id,
+ proc do |results, value|
+ context = "discourse_workflows:workflow:%"
+ if value != :all
+ workflow_id = value.to_s[/\A[1-9]\d*\z/]
+ next results if !workflow_id
+
+ context = DiscourseWorkflows.reviewable_score_context(workflow_id)
+ end
+
+ results.where(<<~SQL, context:)
+ EXISTS (
+ SELECT 1
+ FROM reviewable_scores
+ WHERE reviewable_scores.reviewable_id = reviewables.id
+ AND reviewable_scores.context LIKE :context
+ )
+ SQL
+ end,
+ ],
+ type_filter: {
+ id: "discourse_workflows:workflow",
+ value: :all,
+ },
+ reason_filters: -> do
+ DiscourseWorkflows::Workflow
+ .order(:name)
+ .pluck(:id, :name)
+ .map { |id, name| { id: "discourse_workflows:workflow:#{id}", name:, value: id } }
+ end,
+ )
+
add_to_class(:guardian, :can_manage_workflows?) { is_admin? }
nodes_dir = File.join(File.dirname(__FILE__), "lib/discourse_workflows/nodes")
diff --git a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_post_spec.rb b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_post_spec.rb
index 814a739fdce..1c8aff5d52f 100644
--- a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_post_spec.rb
+++ b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_post_spec.rb
@@ -31,6 +31,7 @@ RSpec.describe DiscourseWorkflows::Nodes::FlagPost::V1 do
expect(score.reviewable_score_type).to eq(ReviewableScore.types[:needs_approval])
expect(score.user).to eq(Discourse.system_user)
expect(score.reason).to eq(attribution)
+ expect(score.context).to eq("discourse_workflows:workflow:#{workflow.id}")
expect(post.reload.hidden?).to eq(false)
expect(result).to include(
"post_id" => post.id,
@@ -92,13 +93,45 @@ RSpec.describe DiscourseWorkflows::Nodes::FlagPost::V1 do
end
it "adds a single score when the same workflow flags the same post twice" do
- execute_node(configuration: { "post_id" => post.id.to_s, "flag_type" => "review" })
+ execute_node(
+ configuration: {
+ "post_id" => post.id.to_s,
+ "flag_type" => "review",
+ },
+ workflow: workflow,
+ )
expect do
- execute_node(configuration: { "post_id" => post.id.to_s, "flag_type" => "review" })
+ execute_node(
+ configuration: {
+ "post_id" => post.id.to_s,
+ "flag_type" => "review",
+ },
+ workflow: workflow,
+ )
end.not_to change { ReviewableScore.count }
end
+ it "records both workflows when they flag the same post" do
+ other_workflow = Fabricate(:discourse_workflows_workflow)
+
+ [workflow, other_workflow].each do |flagging_workflow|
+ execute_node(
+ configuration: {
+ "post_id" => post.id.to_s,
+ "flag_type" => "review",
+ },
+ workflow: flagging_workflow,
+ )
+ end
+
+ reviewable = ReviewablePost.pending.find_by(target: post)
+ expect(reviewable.reviewable_scores.pluck(:context)).to contain_exactly(
+ "discourse_workflows:workflow:#{workflow.id}",
+ "discourse_workflows:workflow:#{other_workflow.id}",
+ )
+ end
+
it "hides the post with review_hide", :aggregate_failures do
result =
execute_node(configuration: { "post_id" => post.id.to_s, "flag_type" => "review_hide" })
@@ -168,6 +201,7 @@ RSpec.describe DiscourseWorkflows::Nodes::FlagPost::V1 do
"flag_type" => "spam",
"actor_username" => moderator.username,
},
+ workflow: workflow,
)
end.to change {
PostAction.where(post: post, post_action_type_id: PostActionType.types[:spam]).count
@@ -176,6 +210,9 @@ RSpec.describe DiscourseWorkflows::Nodes::FlagPost::V1 do
reviewable = ReviewableFlaggedPost.pending.find_by(target: post)
expect(PostAction.last.user).to eq(moderator)
+ expect(reviewable.reviewable_scores.last.context).to eq(
+ "discourse_workflows:workflow:#{workflow.id}",
+ )
expect(post.reload.hidden?).to eq(true)
expect(post.topic.reload.visible).to eq(false)
expect(author.reload.silenced?).to eq(false)
diff --git a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_user_spec.rb b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_user_spec.rb
index 8b90303d363..dff7b206830 100644
--- a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_user_spec.rb
+++ b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/flag_user_spec.rb
@@ -32,6 +32,7 @@ RSpec.describe DiscourseWorkflows::Nodes::FlagUser::V1 do
expect(score.reviewable_score_type).to eq(ReviewableScore.types[:needs_approval])
expect(score.user).to eq(Discourse.system_user)
expect(score.reason).to eq("workflow_flagged_user")
+ expect(score.context).to eq("discourse_workflows:workflow:#{workflow.id}")
expect(result).to include(
"user_id" => target.id,
"username" => target.username,
@@ -43,6 +44,25 @@ RSpec.describe DiscourseWorkflows::Nodes::FlagUser::V1 do
)
end
+ it "records both workflows when they flag the same user" do
+ other_workflow = Fabricate(:discourse_workflows_workflow)
+
+ [workflow, other_workflow].each do |flagging_workflow|
+ execute_node_output(
+ configuration: {
+ "username" => target.username,
+ },
+ workflow: flagging_workflow,
+ )
+ end
+
+ reviewable = ReviewableUser.pending.find_by(target: target)
+ expect(reviewable.reviewable_scores.pluck(:context)).to contain_exactly(
+ "discourse_workflows:workflow:#{workflow.id}",
+ "discourse_workflows:workflow:#{other_workflow.id}",
+ )
+ end
+
it "matches the declared output contract" do
expect(flag).to match_node_output_schema(
described_class,
diff --git a/plugins/discourse-workflows/spec/requests/reviewables_controller_spec.rb b/plugins/discourse-workflows/spec/requests/reviewables_controller_spec.rb
new file mode 100644
index 00000000000..b92d97b9407
--- /dev/null
+++ b/plugins/discourse-workflows/spec/requests/reviewables_controller_spec.rb
@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+
+RSpec.describe ReviewablesController do
+ fab!(:admin)
+ fab!(:workflow, :discourse_workflows_workflow)
+ fab!(:other_workflow, :discourse_workflows_workflow)
+ fab!(:post_reviewable, :reviewable_flagged_post)
+ fab!(:user_reviewable, :reviewable_user)
+ fab!(:unrelated_reviewable, :reviewable_queued_post)
+
+ describe "#index" do
+ before do
+ sign_in(admin)
+ post_reviewable.add_score(
+ Discourse.system_user,
+ ReviewableScore.types[:needs_approval],
+ context: "discourse_workflows:workflow:#{workflow.id}",
+ force_review: true,
+ )
+ user_reviewable.add_score(
+ Discourse.system_user,
+ ReviewableScore.types[:needs_approval],
+ context: "discourse_workflows:workflow:#{other_workflow.id}",
+ force_review: true,
+ )
+ end
+
+ it "adds workflows to Type and current workflow names to Reason" do
+ workflow.update!(name: "Renamed workflow")
+
+ get "/review.json"
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("meta", "reviewable_types")).to include(
+ "discourse_workflows:workflow",
+ )
+ expect(response.parsed_body.dig("meta", "score_types")).to include(
+ { "id" => "discourse_workflows:workflow:#{workflow.id}", "name" => workflow.name },
+ {
+ "id" => "discourse_workflows:workflow:#{other_workflow.id}",
+ "name" => other_workflow.name,
+ },
+ )
+ end
+
+ it "filters posts and users by workflow Type" do
+ get "/review.json", params: { type: "discourse_workflows:workflow" }
+
+ expect(response.status).to eq(200)
+ expect(
+ response.parsed_body["reviewables"].map { |reviewable| reviewable["id"] },
+ ).to contain_exactly(post_reviewable.id, user_reviewable.id)
+ end
+
+ it "filters by workflow Reason after the workflow is renamed" do
+ workflow.update!(name: "Renamed workflow")
+
+ get "/review.json",
+ params: {
+ type: "discourse_workflows:workflow",
+ score_type: "discourse_workflows:workflow:#{workflow.id}",
+ }
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["reviewables"].map { |reviewable| reviewable["id"] }).to eq(
+ [post_reviewable.id],
+ )
+
+ get "/review.json",
+ params: {
+ score_type: "discourse_workflows:workflow:#{other_workflow.id}",
+ }
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["reviewables"].map { |reviewable| reviewable["id"] }).to eq(
+ [user_reviewable.id],
+ )
+ end
+
+ it "filters AI workflow flags after moving from AI Automation", :aggregate_failures do
+ SiteSetting.discourse_ai_enabled = true
+ llm = Fabricate(:llm_model)
+ agent =
+ Fabricate(
+ :ai_agent,
+ default_llm: llm,
+ response_format: [{ "key" => "verdict", "type" => "string" }],
+ )
+ automation = Fabricate(:automation, script: "llm_triage")
+ graph =
+ build_workflow_graph do |graph_builder|
+ graph_builder.node "trigger", "trigger:post_created"
+ graph_builder.node "classify",
+ "action:ai_agent",
+ configuration: {
+ "agent_id" => agent.id,
+ "prompt" => "={{ $trigger.post.raw }}",
+ }
+ graph_builder.node "condition",
+ "condition:if",
+ configuration: {
+ "conditions" => [
+ {
+ "leftValue" => "={{ $json.verdict }}",
+ "rightValue" => "reject",
+ "operator" => {
+ "type" => "string",
+ "operation" => "equals",
+ },
+ },
+ ],
+ }
+ graph_builder.node "flag",
+ "action:flag_post",
+ configuration: {
+ "post_id" => "={{ $trigger.post.id }}",
+ "flag_type" => "review",
+ }
+ graph_builder.chain "trigger", "classify", "condition", "flag"
+ end
+ ai_workflow =
+ Fabricate(:discourse_workflows_workflow, created_by: admin, published: true, **graph)
+ topic_post = create_post
+ Jobs::DiscourseWorkflows::ExecuteWorkflow.jobs.clear
+ fresh_post = create_post(topic_id: topic_post.topic_id)
+ previous_post = create_post(topic_id: topic_post.topic_id)
+ job_args =
+ Jobs::DiscourseWorkflows::ExecuteWorkflow.jobs.map do |job|
+ job["args"].first.symbolize_keys
+ end
+
+ agent.update!(response_format: [])
+ DiscourseAi::Completions::Llm.with_prepared_responses(["bad"]) do
+ DiscourseAi::Automation::LlmTriage.handle(
+ post: previous_post,
+ triage_agent_id: agent.id,
+ search_for_text: "bad",
+ flag_post: true,
+ automation: automation,
+ )
+ end
+ previous_reviewable = ReviewablePost.pending.find_by!(target: previous_post)
+ agent.update!(response_format: [{ "key" => "verdict", "type" => "string" }])
+
+ DiscourseAi::Completions::Llm.with_prepared_responses(
+ [{ verdict: "reject" }.to_json, { verdict: "reject" }.to_json],
+ ) { job_args.each { |args| Jobs::DiscourseWorkflows::ExecuteWorkflow.new.execute(args) } }
+ expect(ai_workflow.executions.pluck(:status)).to contain_exactly("success", "success")
+ fresh_reviewable = ReviewablePost.pending.find_by!(target: fresh_post)
+
+ get "/review.json",
+ params: {
+ type: "discourse_workflows:workflow",
+ score_type: "discourse_workflows:workflow:#{ai_workflow.id}",
+ }
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["reviewables"].map { |item| item["id"] }).to contain_exactly(
+ fresh_reviewable.id,
+ previous_reviewable.id,
+ )
+
+ get "/review.json",
+ params: {
+ type: "discourse_ai:triage",
+ score_type: "ai_triage_automation:#{automation.id}",
+ }
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["reviewables"].map { |item| item["id"] }).to eq(
+ [previous_reviewable.id],
+ )
+
+ expect do
+ DiscourseAi::Completions::Llm.with_prepared_responses([{ verdict: "reject" }.to_json]) do
+ Jobs::DiscourseWorkflows::ExecuteWorkflow.new.execute(job_args.last)
+ end
+ end.not_to change { ReviewableScore.count }
+ expect(ai_workflow.executions.pluck(:status)).to contain_exactly(
+ "success",
+ "success",
+ "success",
+ )
+ end
+
+ it "hides workflow filters when the plugin is disabled" do
+ SiteSetting.enable_discourse_workflows = false
+
+ get "/review.json"
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("meta", "reviewable_types")).not_to include(
+ "discourse_workflows:workflow",
+ )
+ expect(response.parsed_body.dig("meta", "score_types")).not_to include(
+ { "id" => "discourse_workflows:workflow:#{workflow.id}", "name" => workflow.name },
+ )
+ end
+
+ it "ignores malformed workflow IDs" do
+ [true, [workflow.id], { id: workflow.id }, 0, 1.9, "1 OR 1=1 --"].each do |workflow_id|
+ get "/review.json", params: { additional_filters: { workflow_id: }.to_json }
+
+ expect(response.status).to eq(200)
+ expect(
+ response.parsed_body["reviewables"].map { |reviewable| reviewable["id"] },
+ ).to contain_exactly(post_reviewable.id, user_reviewable.id, unrelated_reviewable.id)
+ end
+ end
+ end
+end
diff --git a/plugins/discourse-workflows/spec/system/filter_review_queue_spec.rb b/plugins/discourse-workflows/spec/system/filter_review_queue_spec.rb
new file mode 100644
index 00000000000..704b5501987
--- /dev/null
+++ b/plugins/discourse-workflows/spec/system/filter_review_queue_spec.rb
@@ -0,0 +1,93 @@
+# frozen_string_literal: true
+
+RSpec.describe "Filter review queue by workflow" do
+ include ThemeScreenshotMarker
+
+ fab!(:admin)
+ fab!(:llm, :llm_model)
+ fab!(:agent) do
+ Fabricate(
+ :ai_agent,
+ default_llm: llm,
+ response_format: [{ "key" => "verdict", "type" => "string" }],
+ )
+ end
+
+ let(:editor_page) { PageObjects::Pages::DiscourseWorkflows::WorkflowEditor.new }
+ let(:review_index_page) { PageObjects::Pages::ReviewIndex.new }
+ let(:review_page) { PageObjects::Pages::Review.new }
+
+ before do
+ SiteSetting.discourse_ai_enabled = true
+ SiteSetting.external_system_avatars_url = "/images/avatar.png"
+ GlobalSetting.stubs(:smtp_address).returns("smtp.example.com")
+ sign_in(admin)
+ end
+
+ it "lets an admin find an AI workflow's flagged post by its defined name" do
+ graph =
+ build_workflow_graph do |builder|
+ builder.node "trigger", "trigger:post_created", name: "Post created"
+ builder.node "classify",
+ "action:ai_agent",
+ name: "AI Agent",
+ configuration: {
+ "agent_id" => agent.id,
+ "prompt" => "={{ $trigger.post.raw }}",
+ }
+ builder.node "condition",
+ "condition:if",
+ name: "If",
+ configuration: {
+ "conditions" => [
+ {
+ "leftValue" => "={{ $json.verdict }}",
+ "rightValue" => "reject",
+ "operator" => {
+ "type" => "string",
+ "operation" => "equals",
+ },
+ },
+ ],
+ }
+ builder.node "flag",
+ "action:flag_post",
+ name: "Flag post",
+ configuration: {
+ "post_id" => "={{ $trigger.post.id }}",
+ "flag_type" => "review",
+ }
+ builder.chain "trigger", "classify", "condition", "flag"
+ end
+ workflow_name = "AI content review"
+ workflow =
+ Fabricate(:discourse_workflows_workflow, created_by: admin, name: workflow_name, **graph)
+
+ editor_page.visit(workflow.id)
+ expect(editor_page).to have_name(workflow_name)
+ editor_page.publish
+ editor_page.visit(workflow.id)
+ expect(editor_page).to have_name(workflow_name)
+ expect(editor_page).to have_node_count(4)
+ expect(editor_page).to have_connection_count(3)
+ screenshot_marker(label: "workflow-review-name", only: :desktop)
+
+ post = create_post(title: "Community guidelines", raw: "This post needs a moderator's review.")
+ DiscourseAi::Completions::Llm.with_prepared_responses([{ verdict: "reject" }.to_json]) do
+ Jobs::DiscourseWorkflows::ExecuteWorkflow.jobs.each do |job|
+ Jobs::DiscourseWorkflows::ExecuteWorkflow.new.execute(job["args"].first.symbolize_keys)
+ end
+ end
+ reviewable = ReviewablePost.pending.find_by!(target: post)
+ Fabricate(:reviewable_flagged_post)
+
+ review_index_page.visit
+ review_index_page.expand_filters
+ review_index_page.filter_by_type("Workflows").filter_by_reason(workflow_name)
+ review_index_page.submit_filters
+
+ expect(review_index_page).to have_reason(workflow_name)
+ expect(review_page).to have_reviewables([reviewable])
+ screenshot_marker(label: "workflow-review-queue", only: :desktop)
+ end
+end
diff --git a/plugins/discourse-workflows/spec/system/page_objects/pages/workflow_editor.rb b/plugins/discourse-workflows/spec/system/page_objects/pages/workflow_editor.rb
index 1e6b8e1ced7..7247c462db7 100644
--- a/plugins/discourse-workflows/spec/system/page_objects/pages/workflow_editor.rb
+++ b/plugins/discourse-workflows/spec/system/page_objects/pages/workflow_editor.rb
@@ -172,6 +172,16 @@ module PageObjects
self
end
+ def has_name?(name)
+ page.has_css?(".workflows-editable-title__text", exact_text: name)
+ end
+
+ def publish
+ click_button(I18n.t("js.discourse_workflows.publish"))
+ page.has_no_button?(I18n.t("js.discourse_workflows.publish"))
+ self
+ end
+
def has_node_count?(count)
page.has_css?(".workflow-rete-node", count: count)
end
diff --git a/spec/system/page_objects/pages/review_index.rb b/spec/system/page_objects/pages/review_index.rb
index 033cbb962f0..9c9f48e2ab9 100644
--- a/spec/system/page_objects/pages/review_index.rb
+++ b/spec/system/page_objects/pages/review_index.rb
@@ -3,6 +3,25 @@
module PageObjects
module Pages
class ReviewIndex < PageObjects::Pages::Base
+ def visit
+ page.visit("/review")
+ self
+ end
+
+ def filter_by_type(name)
+ select_filter("review.filters.type.title", name)
+ end
+
+ def filter_by_reason(name)
+ select_filter("review.filters.score_type.title", name)
+ end
+
+ def has_reason?(name)
+ within(filter_container("review.filters.score_type.title")) do
+ page.has_css?(".select-kit-header", text: name)
+ end
+ end
+
def expand_filters
find(".expand-secondary-filters").click
end
@@ -14,6 +33,19 @@ module PageObjects
def claimed_by_select
PageObjects::Components::SelectKit.new(".claimed-by .select-kit")
end
+
+ private
+
+ def select_filter(label_key, name)
+ within(filter_container(label_key)) do
+ PageObjects::Components::SelectKit.new(".select-kit").select_row_by_name(name)
+ end
+ self
+ end
+
+ def filter_container(label_key)
+ find(".filter-label", exact_text: I18n.t("js.#{label_key}")).find(:xpath, "..")
+ end
end
end
end