A platform for community discussion. Free, open, simple.
DEV: cleanup extra i18n key fallback in status_date_label (#38432)
Gabriel Grubbadd2792d00f71
diff --git a/lib/onebox/engine/github_pull_request_onebox.rb b/lib/onebox/engine/github_pull_request_onebox.rbindex 5e98833b4dc..cbbfdb2f747 100644--- a/lib/onebox/engine/github_pull_request_onebox.rb+++ b/lib/onebox/engine/github_pull_request_onebox.rb@@ -91,8 +91,8 @@ module Oneboxenddef status_date_label(status)- key = status.presence || "opened"- I18n.t("onebox.github.status_date.#{key}", default: I18n.t("onebox.github.opened"))+ key = status.presence || "open"+ I18n.t("onebox.github.status_date.#{key}")enddef pr_status_title(status)diff --git a/plugins/discourse-github/spec/lib/github_pr_onebox_status_spec.rb b/plugins/discourse-github/spec/lib/github_pr_onebox_status_spec.rbindex df989f375e9..1d28160adbc 100644--- a/plugins/discourse-github/spec/lib/github_pr_onebox_status_spec.rb+++ b/plugins/discourse-github/spec/lib/github_pr_onebox_status_spec.rb@@ -218,4 +218,25 @@ RSpec.describe Onebox::Engine::GithubPullRequestOnebox doendendend++ describe "#status_date_label" do+ let(:onebox) { Onebox::Engine::GithubPullRequestOnebox.new(gh_link) }++ it "returns the 'open' translation for nil status" do+ result = onebox.send(:status_date_label, nil)+ expect(result).to eq(I18n.t("onebox.github.status_date.open"))+ end++ it "returns the 'open' translation for empty status" do+ result = onebox.send(:status_date_label, "")+ expect(result).to eq(I18n.t("onebox.github.status_date.open"))+ end++ it "returns the correct translation for each status" do+ %w[open draft approved changes_requested merged closed].each do |status|+ result = onebox.send(:status_date_label, status)+ expect(result).to eq(I18n.t("onebox.github.status_date.#{status}"))+ end+ end+ endend