Skip to content

A platform for community discussion. Free, open, simple.

FIX: add guard to prevent jobs from running (#42140)

Amanda Alves Branquinhodd8800925ff4
diff --git a/plugins/discourse-gamification/jobs/scheduled/update_scores_for_ten_days.rb b/plugins/discourse-gamification/jobs/scheduled/update_scores_for_ten_days.rb
index ad1d1d84bd1..23f25706820 100644
--- a/plugins/discourse-gamification/jobs/scheduled/update_scores_for_ten_days.rb
+++ b/plugins/discourse-gamification/jobs/scheduled/update_scores_for_ten_days.rb
@@ -5,6 +5,8 @@ module Jobs
every 1.day
def execute(args = nil)
+ return unless SiteSetting.discourse_gamification_enabled
+
DiscourseGamification::GamificationLeaderboardScore.calculate_all(
since_date: 10.days.ago.midnight,
)
diff --git a/plugins/discourse-gamification/jobs/scheduled/update_scores_for_today.rb b/plugins/discourse-gamification/jobs/scheduled/update_scores_for_today.rb
index 93530727bda..4220ba5cb69 100644
--- a/plugins/discourse-gamification/jobs/scheduled/update_scores_for_today.rb
+++ b/plugins/discourse-gamification/jobs/scheduled/update_scores_for_today.rb
@@ -5,6 +5,8 @@ module Jobs
every 1.hour
def execute(args = nil)
+ return unless SiteSetting.discourse_gamification_enabled
+
DiscourseGamification::GamificationLeaderboardScore.calculate_all
DiscourseGamification::LeaderboardCachedView.purge_all_stale
diff --git a/plugins/discourse-gamification/spec/jobs/update_scores_for_ten_days_spec.rb b/plugins/discourse-gamification/spec/jobs/update_scores_for_ten_days_spec.rb
index 60b36842fb2..2183d91a172 100644
--- a/plugins/discourse-gamification/spec/jobs/update_scores_for_ten_days_spec.rb
+++ b/plugins/discourse-gamification/spec/jobs/update_scores_for_ten_days_spec.rb
@@ -12,6 +12,7 @@ describe Jobs::UpdateScoresForTenDays do
end
before do
+ SiteSetting.discourse_gamification_enabled = true
topic_user_created.update(created_at: 8.days.ago)
topic_user_2_created.update(created_at: 12.days.ago)
end
diff --git a/plugins/discourse-gamification/spec/jobs/update_scores_for_today_spec.rb b/plugins/discourse-gamification/spec/jobs/update_scores_for_today_spec.rb
index 3f8ec02820a..dd55cdbf8ba 100644
--- a/plugins/discourse-gamification/spec/jobs/update_scores_for_today_spec.rb
+++ b/plugins/discourse-gamification/spec/jobs/update_scores_for_today_spec.rb
@@ -16,7 +16,10 @@ describe Jobs::UpdateScoresForToday do
described_class.new.execute
end
- before { topic_user_2_created.update(created_at: 2.days.ago) }
+ before do
+ SiteSetting.discourse_gamification_enabled = true
+ topic_user_2_created.update(created_at: 2.days.ago)
+ end
it "updates all scores for today" do
run_job