A platform for community discussion. Free, open, simple.
FIX: Handle boolean values in version check response (#38786)
David Taylorde973de2b654
diff --git a/lib/discourse_updates.rb b/lib/discourse_updates.rbindex 4d8bd60d840..d25569658bd 100644--- a/lib/discourse_updates.rb+++ b/lib/discourse_updates.rb@@ -113,7 +113,7 @@ module DiscourseUpdatesversion_keys = []versions[0, 5].each do |v|key = "#{missing_versions_key_prefix}:#{v["version"]}"- Discourse.redis.mapped_hmset key, v+ Discourse.redis.mapped_hmset key, v.slice("version", "notes")version_keys << keyendDiscourse.redis.rpush missing_versions_list_key, version_keysdiff --git a/spec/jobs/call_discourse_hub_spec.rb b/spec/jobs/call_discourse_hub_spec.rbindex 890c8e66557..1f4afe7547d 100644--- a/spec/jobs/call_discourse_hub_spec.rb+++ b/spec/jobs/call_discourse_hub_spec.rb@@ -12,5 +12,38 @@ RSpec.describe Jobs::CallDiscourseHub dodescribed_class.new.execute({})endend++ context "when version_checks enabled" do+ before do+ SiteSetting.version_checks = true+ SiteSetting.include_in_discourse_discover = false+ end++ it "stores missing versions from the hub response" do+ DiscourseHub.stubs(:discourse_version_check).returns(+ {+ "latestVersion" => "2026.3.1",+ "criticalUpdates" => false,+ "missingVersionsCount" => 2,+ "versions" => [+ { "version" => "2026.3.1", "notes" => "Latest release", "critical" => true },+ { "version" => "2026.2.5", "notes" => "Security patch", "critical" => false },+ ],+ },+ )++ described_class.new.execute({})++ expect(DiscourseUpdates).to have_attributes(+ latest_version: "2026.3.1",+ missing_versions_count: 2,+ missing_versions:+ contain_exactly(+ { "version" => "2026.3.1", "notes" => "Latest release" },+ { "version" => "2026.2.5", "notes" => "Security patch" },+ ),+ )+ end+ endendend