Skip to content

A platform for community discussion. Free, open, simple.

DEV: Update tag specs 403 -> 404

David Taylordf94d46a7328
diff --git a/spec/requests/tags_controller_spec.rb b/spec/requests/tags_controller_spec.rb
index 35a31916f55..73d9993b839 100644
--- a/spec/requests/tags_controller_spec.rb
+++ b/spec/requests/tags_controller_spec.rb
@@ -996,13 +996,13 @@ RSpec.describe TagsController do
expect(response.status).to eq(403)
end
- it "returns 403 when tag is hidden and user is not in permitted group" do
+ it "returns 404 when tag is hidden and user is not in permitted group" do
SiteSetting.edit_tags_allowed_groups = "1|2|3|13"
Fabricate(:tag_group, permissions: { "staff" => 1 }, tag_names: [tag.name])
sign_in(regular_user)
put "/tag/#{tag.name}.json", params: { tag: { description: "New description" } }
- expect(response.status).to eq(403)
+ expect(response.status).to eq(404)
end
it "returns 404 for non-existing tags" do
@@ -1791,12 +1791,12 @@ RSpec.describe TagsController do
expect(response.status).to eq(200)
end
- it "returns 403 when tag is hidden and user is not in permitted group" do
+ it "returns 404 when tag is hidden and user is not in permitted group" do
SiteSetting.edit_tags_allowed_groups = "1|2|13"
Fabricate(:tag_group, permissions: { "staff" => 1 }, tag_names: [tag.name])
sign_in(regular_user)
post "/tag/#{tag.name}/synonyms.json", params: { tags: [{ name: "synonym1" }] }
- expect(response.status).to eq(403)
+ expect(response.status).to eq(404)
end
it "succeeds when tag is hidden and user is admin" do