Skip to content

A platform for community discussion. Free, open, simple.

PERF: Patch WarpDrive to drop `json-to-ast` from production bundles (#44774)

David Taylore01f67785443
diff --git a/patches/@[email protected] b/patches/@[email protected]
new file mode 100644
index 00000000000..081152b21fe
--- /dev/null
+++ b/patches/@[email protected]
@@ -0,0 +1,30 @@
+diff --git a/dist/index.js b/dist/index.js
+index a9490fa509546ef484eddb61c5433dc15f127214..aab49f54e6c95d1f94a7ba4baa6d0565de820f61 100644
+--- a/dist/index.js
++++ b/dist/index.js
+@@ -1,8 +1,7 @@
+ import { graphFor, peekGraph, isBelongsTo } from '@warp-drive/core/graph/-private';
+ import { logGroup, isResourceKey, assertPrivateCapabilities, isRequestKey } from '@warp-drive/core/store/-private';
+ import Fuse from 'fuse.js';
+-import jsonToAst from 'json-to-ast';
+-import { macroCondition, getGlobalConfig } from '@embroider/macros';
++import { macroCondition, getGlobalConfig, importSync } from '@embroider/macros';
+
+ function validateDocumentFields(schema, jsonApiDoc) {
+ const {
+@@ -214,9 +213,12 @@ class Reporter {
+ this.capabilities = capabilities;
+ this.contextDocument = doc;
+ this.jsonStr = JSON.stringify(doc.content, null, 2);
+- this.ast = jsonToAst(this.jsonStr, {
+- loc: true
+- });
++ if (macroCondition(getGlobalConfig().WarpDrive.env.DEBUG)) {
++ const jsonToAst = importSync('json-to-ast').default;
++ this.ast = jsonToAst(this.jsonStr, {
++ loc: true
++ });
++ }
+ }
+ searchTypes(type) {
+ if (!this._typeFilter) {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 90d5a3c7f48..ccc4c09a285 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -169,6 +169,7 @@ overrides:
patchedDependencies:
+ '@warp-drive/[email protected]': 8a9a8808d6b8632a4fbab8240855ec8a12583f7a48fc8d04c142b89ecc90f4ee
'@warp-drive/[email protected]': de74ff6c540d75d173dcb41244cb6c4f6c86dabdb41908170a9d1c0e47ee099f
[email protected]: 387f93bad78f3a98b20dc742f4f0b7a165c7e6ebc65cc60356748346c0725c7f
[email protected]: aa23a9187235d165dee5e57e37f5310baafb88869fb08c274dca853d6b804201
@@ -452,7 +453,7 @@ importers:
'@warp-drive/json-api':
specifier: 5.9.0-alpha.15
+ version: 5.9.0-alpha.15(patch_hash=8a9a8808d6b8632a4fbab8240855ec8a12583f7a48fc8d04c142b89ecc90f4ee)(@babel/[email protected]([email protected]))(@glint/[email protected])(@warp-drive/[email protected](@babel/[email protected]([email protected]))(@glint/[email protected])([email protected]))([email protected])
'@warp-drive/legacy':
specifier: 5.9.0-alpha.15
version: 5.9.0-alpha.15(patch_hash=de74ff6c540d75d173dcb41244cb6c4f6c86dabdb41908170a9d1c0e47ee099f)(@babel/[email protected]([email protected]))(@glint/[email protected])(@warp-drive/[email protected](@babel/[email protected]([email protected]))(@glint/[email protected])([email protected]))(@warp-drive/[email protected](@babel/[email protected]([email protected]))(@glint/[email protected])(@warp-drive/[email protected](@babel/[email protected]([email protected]))(@glint/[email protected])([email protected]))([email protected]))([email protected])
@@ -10937,7 +10938,7 @@ snapshots:
- '@glint/template'
- supports-color
+ '@warp-drive/[email protected](patch_hash=8a9a8808d6b8632a4fbab8240855ec8a12583f7a48fc8d04c142b89ecc90f4ee)(@babel/[email protected]([email protected]))(@glint/[email protected])(@warp-drive/[email protected](@babel/[email protected]([email protected]))(@glint/[email protected])([email protected]))([email protected])':
dependencies:
'@embroider/macros': 1.21.3(@babel/[email protected]([email protected]))(@glint/[email protected])([email protected])
'@warp-drive/core': 5.9.0-alpha.15(@babel/[email protected]([email protected]))(@glint/[email protected])([email protected])
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index f653451f7e1..c5e7d95c48d 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -77,6 +77,8 @@ patchedDependencies:
"licensee": "patches/licensee.patch"
# https://github.com/warp-drive-data/warp-drive/pull/11037
"@warp-drive/[email protected]": "patches/@[email protected]"
+ # https://github.com/warp-drive-data/warp-drive/pull/11499
+ "@warp-drive/[email protected]": "patches/@[email protected]"
"pikaday": "patches/pikaday.patch"