Skip to content

A platform for community discussion. Free, open, simple.

FIX: Reply-to user serialization should respect enable_names setting (#40890)

Isaac Janzene098064ab4a1
diff --git a/app/serializers/post_serializer.rb b/app/serializers/post_serializer.rb
index f78bce2087c..375dccf99ff 100644
--- a/app/serializers/post_serializer.rb
+++ b/app/serializers/post_serializer.rb
@@ -313,12 +313,7 @@ class PostSerializer < BasicPostSerializer
end
def reply_to_user
- {
- id: object.reply_to_user.id,
- username: object.reply_to_user.username,
- name: object.reply_to_user.name,
- avatar_template: object.reply_to_user.avatar_template,
- }
+ BasicUserSerializer.new(object.reply_to_user, root: false).as_json
end
def deleted_by
diff --git a/spec/requests/topics_controller_spec.rb b/spec/requests/topics_controller_spec.rb
index 9dca2cd550b..b1f85d167c9 100644
--- a/spec/requests/topics_controller_spec.rb
+++ b/spec/requests/topics_controller_spec.rb
@@ -4564,6 +4564,30 @@ RSpec.describe TopicsController do
expect(body["suggested_topics"]).not_to eq(nil)
end
+ it "omits reply-to user names when names are disabled" do
+ SiteSetting.enable_names = false
+ post.user.update!(name: "Hidden Reply Target")
+ reply =
+ Fabricate(
+ :post,
+ topic: topic,
+ user: post_author2,
+ reply_to_post_number: post.post_number,
+ reply_to_user_id: post.user_id,
+ )
+
+ get "/t/#{topic.id}/posts.json", params: { post_ids: [reply.id] }
+
+ expect(response.status).to eq(200)
+ posts = response.parsed_body["post_stream"]["posts"]
+ reply_post = posts.find { |post_json| post_json["id"] == reply.id }
+ reply_to_user = reply_post["reply_to_user"]
+
+ expect(reply_to_user).to include("id" => post.user_id, "username" => post.user.username)
+ expect(reply_to_user).not_to have_key("name")
+ expect(response.body).not_to include(post.user.name)
+ end
+
it "optionally can return raw" do
get "/t/#{topic.id}/posts.json?include_raw=true&post_id[]=#{post.id}"