A platform for community discussion. Free, open, simple.
PERF: Skip color scheme lookups without a preference (#44469)
Alan Guo Xiang Tane2af323fb4bf
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rbindex 251109ace1c..0eafeca13ee 100644--- a/app/helpers/application_helper.rb+++ b/app/helpers/application_helper.rb@@ -676,6 +676,7 @@ module ApplicationHelperdef user_scheme_idreturn @user_scheme_id if defined?(@user_scheme_id)scheme_id = cookies[:color_scheme_id] || current_user&.user_option&.color_scheme_id+ return if scheme_id.nil?@user_scheme_id = ColorScheme.valid_id(scheme_id) if ColorScheme.exists?(id: scheme_id,@@ -703,6 +704,7 @@ module ApplicationHelperdef user_dark_scheme_idreturn @user_dark_scheme_id if defined?(@user_dark_scheme_id)scheme_id = cookies[:dark_scheme_id] || current_user&.user_option&.dark_scheme_id+ return if scheme_id.nil?@user_dark_scheme_id = ColorScheme.valid_id(scheme_id) if ColorScheme.exists?(id: scheme_id,