A platform for community discussion. Free, open, simple.
PERF: Skip unused topic preloads in crawler views (#44330)
Natalie Taye35f05c5dd1b
diff --git a/app/controllers/topics_controller.rb b/app/controllers/topics_controller.rbindex a6d8509bc8f..0bcd21bba9b 100644--- a/app/controllers/topics_controller.rb+++ b/app/controllers/topics_controller.rb@@ -1578,7 +1578,9 @@ class TopicsController < ApplicationControllerend@breadcrumbs = helpers.categories_breadcrumb(@topic_view.topic) || []@description_meta = @topic_view.topic.plain_text_excerpt || @topic_view.summary- store_preloaded("topic_#{@topic_view.topic.id}", MultiJson.dump(topic_view_serializer))+ if set_layout == "application"+ store_preloaded("topic_#{@topic_view.topic.id}", MultiJson.dump(topic_view_serializer))+ endrender :showenddiff --git a/spec/requests/topics_controller_spec.rb b/spec/requests/topics_controller_spec.rbindex efbaa14d8d4..640ae8f8458 100644--- a/spec/requests/topics_controller_spec.rb+++ b/spec/requests/topics_controller_spec.rb@@ -7659,6 +7659,35 @@ RSpec.describe TopicsController doenddescribe "crawler" do+ it "preloads the topic when a crawler requests the desktop layout" do+ get topic.relative_url,+ headers: {+ "User-Agent" => "Googlebot",+ "Discourse-Render" => "desktop",+ }++ expect(response.status).to eq(200)+ expect(response.body).to have_tag("script#data-preloaded") do |element|+ preloaded = JSON.parse(element.current_scope.text)+ expect(JSON.parse(preloaded["topic_#{topic.id}"])["id"]).to eq(topic.id)+ end+ end++ it "renders posts without preloaded data when a browser requests the crawler layout" do+ post = Fabricate(:post, topic:)++ get topic.relative_url,+ headers: {+ "User-Agent" => "Mozilla/5.0 Chrome/130.0.0.0 Safari/537.36",+ "Discourse-Render" => "crawler",+ }++ expect(response.status).to eq(200)+ expect(response.body).to have_tag(:body, with: { class: "crawler" })+ expect(response.body).to include(post.cooked)+ expect(response.body).not_to have_tag("script#data-preloaded")+ end+context "when not a crawler" doit "renders with the application layout" doget topic.relative_url@@ -7667,6 +7696,10 @@ RSpec.describe TopicsController doexpect(body).to have_tag(:script, with: { "data-discourse-entrypoint" => "discourse" })expect(body).to have_tag(:meta, with: { name: "fragment" })+ expect(body).to have_tag("script#data-preloaded") do |element|+ preloaded = JSON.parse(element.current_scope.text)+ expect(JSON.parse(preloaded["topic_#{topic.id}"])["id"]).to eq(topic.id)+ endendit "renders the excerpt in the meta description decoded exactly once and tag-free" do